Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning/importinto: set correct step to create single point allocator #56602

Merged
merged 3 commits into from
Oct 12, 2024

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Oct 12, 2024

What problem does this PR solve?

Issue Number: close #56476

Problem Summary:

What changed and how does it work?

we must set autoid.CustomAutoIncCacheOption(1) to create a new single point allocator, else it's always normal one

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

import into is test manually with same case as lightning. when I try add to real-tikv-test, it report autoid service leader not found, something might not be mocked.

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 12, 2024
Copy link

tiprow bot commented Oct 12, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter D3Hunter changed the title lightning/importinto: set correct step for single point allocator lightning/importinto: set correct step to create single point allocator Oct 12, 2024
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.5404%. Comparing base (7158ac6) to head (9817a76).
Report is 383 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56602         +/-   ##
=================================================
- Coverage   73.3956%   56.5404%   -16.8552%     
=================================================
  Files          1628       1778        +150     
  Lines        449554     637027     +187473     
=================================================
+ Hits         329953     360178      +30225     
- Misses        99341     252223     +152882     
- Partials      20260      24626       +4366     
Flag Coverage Δ
integration 38.2213% <100.0000%> (?)
unit 72.5620% <100.0000%> (+0.0609%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.4375% <ø> (+6.8395%) ⬆️

@D3Hunter D3Hunter requested a review from lance6716 October 12, 2024 05:59
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 12, 2024
@lance6716
Copy link
Contributor

/cc @tiancaiamao

@ti-chi-bot ti-chi-bot bot requested a review from tiancaiamao October 12, 2024 06:10
@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Oct 12, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented Oct 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 12, 2024
Copy link

ti-chi-bot bot commented Oct 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-12 06:10:27.940013602 +0000 UTC m=+78625.088923434: ☑️ agreed by lance6716.
  • 2024-10-12 06:47:06.82878427 +0000 UTC m=+80823.977694102: ☑️ agreed by tiancaiamao.

@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Oct 12, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit ea55064 into pingcap:master Oct 12, 2024
24 checks passed
@D3Hunter D3Hunter deleted the fix-initial-incr-autoid1 branch October 12, 2024 16:13
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Oct 31, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 31, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #57025.

@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Dec 3, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #57925.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 3, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect AUTO_INCREMENT Value After Data Import Causing Duplicate Key Error(when AUTO_ID_CACHE=1)
4 participants