Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner, stats: skip (auto) analyze on vector column and index #56584

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

winoros
Copy link
Member

@winoros winoros commented Oct 11, 2024

What problem does this PR solve?

Issue Number: close #56583

Problem Summary:

What changed and how does it work?

This pull does two things:

  • Auto analyze will not be affected by indexes on vector columns anymore.
  • Vector type column will not collect any stats now.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 56.4877%. Comparing base (ca8d322) to head (0f0f915).
Report is 6 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56584         +/-   ##
=================================================
- Coverage   73.4053%   56.4877%   -16.9176%     
=================================================
  Files          1629       1778        +149     
  Lines        449951     638092     +188141     
=================================================
+ Hits         330288     360444      +30156     
- Misses        99390     252995     +153605     
- Partials      20273      24653       +4380     
Flag Coverage Δ
integration 38.0490% <4.5454%> (?)
unit 72.4690% <50.0000%> (-0.0708%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.3907% <ø> (+6.8048%) ⬆️

@winoros
Copy link
Member Author

winoros commented Oct 11, 2024

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 14, 2024
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Please fill your PR body. Thanks!

Approve in advance.

pkg/planner/core/planbuilder.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2024
Copy link

ti-chi-bot bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, Rustin170506

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 14, 2024
Copy link

ti-chi-bot bot commented Oct 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-14 10:22:38.763049108 +0000 UTC m=+266555.911958940: ☑️ agreed by hawkingrei.
  • 2024-10-14 17:18:10.313479863 +0000 UTC m=+291487.462389695: ☑️ agreed by Rustin170506.

Co-authored-by: Rustin <29879298+Rustin170506@users.noreply.github.com>
@winoros
Copy link
Member Author

winoros commented Oct 14, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2024
@ti-chi-bot ti-chi-bot bot merged commit ee4b86d into pingcap:master Oct 14, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto analyze will be triggered repeatedly when there's any vector index.
3 participants