-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: handle lock and unlock operations correctly #56454
base: master
Are you sure you want to change the base?
statistics: handle lock and unlock operations correctly #56454
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #56454 +/- ##
=================================================
- Coverage 73.3500% 56.4439% -16.9061%
=================================================
Files 1629 1779 +150
Lines 450090 636990 +186900
=================================================
+ Hits 330141 359542 +29401
- Misses 99710 252872 +153162
- Partials 20239 24576 +4337
Flags with carried forward coverage won't be shown. Click here to find out more.
|
602f8ef
to
c1025de
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
c1025de
to
c909968
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3233a85
to
c7f1fa5
Compare
/retest |
30d62ab
to
0aeb71a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔢 Self-check (PR reviewed by myself and ready for feedback.)
0aeb71a
to
a5c961b
Compare
Better comment
a5c961b
to
bc8c0e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔢 Self-check (PR reviewed by myself and ready for feedback.)
/retest |
What problem does this PR solve?
Issue Number: ref #55906
Problem Summary:
What changed and how does it work?
This PR is based on #56437
Handle the lock and unlock operations correctly.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.