-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: fix errors set utc_timestamp precision | tidb-test=pr/2406 #56453
base: master
Are you sure you want to change the base?
Conversation
Welcome @chagelo! |
Hi @chagelo. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @chagelo. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
@chagelo: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@chagelo: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just missing the statement in the .test file.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #56453 +/- ##
=================================================
- Coverage 73.3414% 56.3106% -17.0309%
=================================================
Files 1629 1753 +124
Lines 449976 633500 +183524
=================================================
+ Hits 330019 356728 +26709
- Misses 99734 252786 +153052
- Partials 20223 23986 +3763
Flags with carried forward coverage won't be shown. Click here to find out more.
|
353bffc
to
0229b66
Compare
Thank you very much for the suggestions! And I'm gonna fix the rest errors tomorrow.😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I have re-recorded the test results for the failing CI test idc-jenkins-ci-tidb/mysql-test
, which is a private repository for various integration tests and mysql compatibility tests. so hopefully the tests will pass.
/retest |
1 similar comment
/retest |
/run-check-issue-triage-complete |
There are a few places that check for a
Maybe:
Side note: Looks like there is a MySQL bug in the error message that we don't follow: MySQL 9.0.1:
TiDB:
|
For the bug in MySQL: |
Inspired by the MySQL bug it looks like we have a similar bug (but way less severe). This also answers my question about negative fsp's somewhat:
|
|
8f0e846
to
52dbcb0
Compare
52dbcb0
to
a2b0d7b
Compare
MariaDB seems to be more strict than MySQL here. Looks like MariaDB accepts larger numbers in the parser but checks them later on.
|
/retest |
@chagelo are the tests failing for something related to this PR? |
@dveeden yes, it is.
|
I don't think we should follow the behavior of https://bugs.mysql.com/bug.php?id=116307 as I don't think people are relying on this behavior or should rely on this behavior.
I'm not sure. One of the issues with having the parser deal with things is that it might not have the right context to fill in the fields of the error message (e.g. the name of the table or the name of the function). |
From the issue description:
It looks like these are all fixed. The following might be seen as a separate bug if it is not a regression:
Note that this is somewhat similar to #46372 (comment) |
a2b0d7b
to
33af583
Compare
/retest |
It seems TiDB parser handles the negative precision, but not resolve the overlong number precision, parser should have dealt with this, because this error contains some context. |
@dveeden Required review. Thanks. |
What problem does this PR solve?
Issue Number: close #56451
Problem Summary:
What changed and how does it work?
Correct the error when set invalid precision for
utc_timestamp
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.