Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sessionctx,infoschema: change @@tidb_schema_cache_size lower bound to 64MB #56316

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #50959

Problem Summary:

What changed and how does it work?

I've tested the relationship between schema cache size and active tables been keep in-memory.

  • 95208 tables => 103MB cache size to make them all in memory
  • 151641 tables => 163MB
  • 200062 tables => 216MB

On average, 1M schema cache size can cache 926 active tables.
So 64MB schema cache size can keep nearly 60K active tables in memory.
128MB schema cache size can keep nearly 120K active tables in memory.

The default schema cache size is still 512MB which is large enough for 475K active tables.
This change makes it easier to cover cache miss cases.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Test different table numbers and check the corresponding @@tidb_schema_cache_size can make them all in-memory.
(This can be verified by check the metrics with active workload visiting a varity of tables)

Test with 1M tables with workload visiting tables [0-500000] in 0-2min, tables [500000-1000000) in 2-4min, and than [0-500000] again in 4-6min ... change the table range every 2min and watch the cache miss behaviour:

image

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 25, 2024
Copy link

tiprow bot commented Sep 25, 2024

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.2698%. Comparing base (a997f95) to head (9096ae8).
Report is 22 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #56316        +/-   ##
================================================
+ Coverage   73.3850%   76.2698%   +2.8847%     
================================================
  Files          1605       1641        +36     
  Lines        445291     462689     +17398     
================================================
+ Hits         326777     352892     +26115     
+ Misses        98457      88268     -10189     
- Partials      20057      21529      +1472     
Flag Coverage Δ
integration 52.3873% <100.0000%> (?)
unit 72.7635% <100.0000%> (+0.2494%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 60.7653% <ø> (+14.7343%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 25, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 25, 2024
Copy link

ti-chi-bot bot commented Sep 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-25 13:35:30.324121874 +0000 UTC m=+1659400.064545810: ☑️ agreed by lance6716.
  • 2024-09-25 13:45:14.779369941 +0000 UTC m=+1659984.519793879: ☑️ agreed by CbcWestwolf.

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 26, 2024
@tiancaiamao
Copy link
Contributor Author

/test unit-test

Copy link

tiprow bot commented Sep 26, 2024

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, lance6716, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 26, 2024
@tiancaiamao
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Sep 26, 2024

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tiancaiamao
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Sep 26, 2024

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tiancaiamao
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Sep 26, 2024
@ti-chi-bot ti-chi-bot bot merged commit d788e3c into pingcap:master Sep 26, 2024
25 checks passed
@tiancaiamao tiancaiamao deleted the min-cache-size branch September 26, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants