-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: remove EnablePointGetCache
session var
#55697
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
I found a similar PR #48962 🤦. @Defined2014 Why do you close it? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #55697 +/- ##
================================================
+ Coverage 72.9203% 74.7898% +1.8695%
================================================
Files 1581 1582 +1
Lines 442365 442632 +267
================================================
+ Hits 322574 331044 +8470
+ Misses 99982 91292 -8690
- Partials 19809 20296 +487
Flags with carried forward coverage won't be shown. Click here to find out more.
|
The session variable is removed by an accident. And we try to add back it before #51008 But this was rejected, I think it's good to remove it. If I remember correctly, this feature was designed for POC and was never mentioned in the documentation. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Defined2014, lance6716 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GetMemCache should be removed too,
/assign @yudongusa |
@lance6716: GitHub didn't allow me to assign the following users: yudongusa. Note that only pingcap members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@YangKeao: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #55696
Problem Summary:
These codes are not modified for a very long time, and there is no option to enable this session var. Therefore, I think maybe it's safe to remove it 🤔.
What changed and how does it work?
Simply remove the codes related to
EnablePointGetCache
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.