Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: remove EnablePointGetCache session var #55697

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YangKeao
Copy link
Member

What problem does this PR solve?

Issue Number: close #55696

Problem Summary:

These codes are not modified for a very long time, and there is no option to enable this session var. Therefore, I think maybe it's safe to remove it 🤔.

What changed and how does it work?

Simply remove the codes related to EnablePointGetCache.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.
      This PR doesn't change the existing logic. The existing tests about normal point get should cover it.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 27, 2024
@YangKeao
Copy link
Member Author

I found a similar PR #48962 🤦. @Defined2014 Why do you close it?

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.7898%. Comparing base (3d42e34) to head (9eddc89).
Report is 599 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #55697        +/-   ##
================================================
+ Coverage   72.9203%   74.7898%   +1.8695%     
================================================
  Files          1581       1582         +1     
  Lines        442365     442632       +267     
================================================
+ Hits         322574     331044      +8470     
+ Misses        99982      91292      -8690     
- Partials      19809      20296       +487     
Flag Coverage Δ
integration 48.9566% <ø> (?)
unit 71.8769% <ø> (-0.1265%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 52.1762% <ø> (+6.9140%) ⬆️

@Defined2014
Copy link
Contributor

Defined2014 commented Aug 27, 2024

I found a similar PR #48962 🤦. @Defined2014 Why do you close it?

The session variable is removed by an accident. And we try to add back it before #51008 But this was rejected, I think it's good to remove it. If I remember correctly, this feature was designed for POC and was never mentioned in the documentation.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 27, 2024
Copy link

ti-chi-bot bot commented Aug 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Defined2014, lance6716
Once this PR has been reviewed and has the lgtm label, please assign easonn7 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 27, 2024
Copy link

ti-chi-bot bot commented Aug 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-27 09:58:16.149650358 +0000 UTC m=+864291.284100488: ☑️ agreed by Defined2014.
  • 2024-08-27 14:03:58.630706369 +0000 UTC m=+879033.765156489: ☑️ agreed by lance6716.

Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetMemCache should be removed too,

@lance6716
Copy link
Contributor

/assign @yudongusa

Copy link

ti-chi-bot bot commented Aug 29, 2024

@lance6716: GitHub didn't allow me to assign the following users: yudongusa.

Note that only pingcap members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @yudongusa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 6, 2024
Copy link

ti-chi-bot bot commented Sep 6, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented Nov 18, 2024

@YangKeao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-integration-e2e-test 9eddc89 link true /test pull-integration-e2e-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EnablePointGetCache can be removed
4 participants