Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domain/rg: organize and enhance the code of RunawayChecker #55331

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Aug 9, 2024

What problem does this PR solve?

Issue Number: ref #54434.

What changed and how does it work?

  • Delete some unnecessary code.
  • Add more comments.
  • Organize and enhance some functions.

Check List

Tests

  • Unit test
  • Integration test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 9, 2024
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 82.71605% with 14 lines in your changes missing coverage. Please review.

Project coverage is 75.6536%. Comparing base (eeb3d73) to head (c6dce55).
Report is 4 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #55331        +/-   ##
================================================
+ Coverage   74.8640%   75.6536%   +0.7896%     
================================================
  Files          1576       1598        +22     
  Lines        365691     449887     +84196     
================================================
+ Hits         273771     340356     +66585     
- Misses        72108      88386     +16278     
- Partials      19812      21145      +1333     
Flag Coverage Δ
integration 52.1828% <0.0000%> (?)
unit 72.0936% <82.7160%> (-1.7368%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (-2.2327%) ⬇️
parser ∅ <ø> (∅)
br 63.1882% <ø> (+15.3901%) ⬆️

@JmPotato JmPotato force-pushed the enhance_runaway_checker branch 3 times, most recently from e57597a to caa05bf Compare August 12, 2024 17:15
@HuSharp
Copy link
Contributor

HuSharp commented Aug 13, 2024

/retest-required

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 14, 2024
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Copy link
Member Author

JmPotato commented Aug 14, 2024

/cc @nolouch @glorv @HuSharp

PTAL

@ti-chi-bot ti-chi-bot bot requested review from glorv, HuSharp and nolouch August 14, 2024 08:24
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 14, 2024
Copy link

ti-chi-bot bot commented Aug 14, 2024

@HuSharp: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 14, 2024
@D3Hunter
Copy link
Contributor

/approve

for domain pkg

@ti-chi-bot ti-chi-bot bot added the approved label Aug 14, 2024
Copy link

ti-chi-bot bot commented Aug 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, glorv, HuSharp, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 14, 2024
Copy link

ti-chi-bot bot commented Aug 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-14 08:39:07.99363281 +0000 UTC m=+343632.697102454: ☑️ agreed by glorv.
  • 2024-08-14 08:57:30.301983234 +0000 UTC m=+344735.005452889: ☑️ agreed by nolouch.

@ti-chi-bot ti-chi-bot bot merged commit afd7b97 into pingcap:master Aug 14, 2024
24 checks passed
@JmPotato JmPotato deleted the enhance_runaway_checker branch August 14, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants