-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: enable infoschema v2 by default #55229
*: enable infoschema v2 by default #55229
Conversation
Hi @tiancaiamao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #55229 +/- ##
================================================
+ Coverage 74.8397% 75.7356% +0.8959%
================================================
Files 1575 1578 +3
Lines 365139 447571 +82432
================================================
+ Hits 273269 338971 +65702
- Misses 72116 88636 +16520
- Partials 19754 19964 +210
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test unit-test |
@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the master testing, and should be turn off before released. Later to consider turn on by default when GA.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, tangenta, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #50959
Problem Summary:
Before we make this change GA, we need to make sure it is stable enough.
What changed and how does it work?
On master branch, we would make it enabled by default, and run the whole period during v8.3 ~ v8.4 / v8.5
And if it's stable enough, we'll announce GA in v8.5 (LTS version)
This change would not be in v8.3, just for the master branch.
Check List
Tests
Once we run infoschema v2 by default, all the tests cover it.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.