Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txn: restore failed due to file end key is empty (#52572) #54998

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #52572

What problem does this PR solve?

Issue Number: close #52574

Problem Summary:
Restore txn kv might failed about handling empty end key. This PR fixed it.

What changed and how does it work?

Don't encode empty value of end key.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that restore txn kv may report invalid range error.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Jul 29, 2024
@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. labels Jul 29, 2024
@3pointer
Copy link
Contributor

/test pull_br_integration_test

Copy link

ti-chi-bot bot commented Jul 29, 2024

@3pointer: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test pull-br-integration-test
  • /test pull-lightning-integration-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/release-8.1/ghpr_build
  • pingcap/tidb/release-8.1/ghpr_check
  • pingcap/tidb/release-8.1/ghpr_check2
  • pingcap/tidb/release-8.1/ghpr_mysql_test
  • pingcap/tidb/release-8.1/ghpr_unit_test

In response to this:

/test pull_br_integration_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

tiprow bot commented Jul 29, 2024

@3pointer: No presubmit jobs available for pingcap/tidb@release-8.1

In response to this:

/test pull_br_integration_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@3pointer
Copy link
Contributor

/test pull-br-integration-test

Copy link

tiprow bot commented Jul 29, 2024

@3pointer: No presubmit jobs available for pingcap/tidb@release-8.1

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@42b624c). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #54998   +/-   ##
================================================
  Coverage               ?   71.3071%           
================================================
  Files                  ?       1465           
  Lines                  ?     422534           
  Branches               ?          0           
================================================
  Hits                   ?     301297           
  Misses                 ?     100797           
  Partials               ?      20440           
Flag Coverage Δ
unit 71.3071% <71.4285%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.0740% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 29, 2024
Copy link

ti-chi-bot bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 29, 2024
Copy link

ti-chi-bot bot commented Jul 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-29 09:07:48.394841301 +0000 UTC m=+173984.674889370: ☑️ agreed by 3pointer.
  • 2024-07-29 09:21:02.017039583 +0000 UTC m=+174778.297087652: ☑️ agreed by Leavrth.

@ti-chi-bot ti-chi-bot bot merged commit 80d4dec into pingcap:release-8.1 Jul 29, 2024
31 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants