Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: update the resource controller to support fallback #54621

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Jul 15, 2024

What problem does this PR solve?

Issue Number: close #54453, ref #54434.

What changed and how does it work?

Update the resource controller to adopt tikv/pd#8387 and tikv/pd#8402.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Support multiple dynamic changes:

No interruption even after the GC cleanup:

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 15, 2024
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.9484%. Comparing base (ca7ba14) to head (324f9f6).
Report is 14 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54621         +/-   ##
=================================================
- Coverage   74.6668%   55.9484%   -18.7185%     
=================================================
  Files          1551       1672        +121     
  Lines        362786     609227     +246441     
=================================================
+ Hits         270881     340853      +69972     
- Misses        72307     245078     +172771     
- Partials      19598      23296       +3698     
Flag Coverage Δ
integration 37.1033% <ø> (?)
unit 71.7212% <ø> (-1.8722%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (-2.2339%) ⬇️
parser ∅ <ø> (∅)
br 52.5676% <ø> (+4.9075%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 16, 2024
@JmPotato
Copy link
Member Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2024
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2024
Copy link

ti-chi-bot bot commented Jul 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nolouch, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 18, 2024
Copy link

ti-chi-bot bot commented Jul 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-16 03:12:09.530920683 +0000 UTC m=+323551.521862153: ☑️ agreed by xhebox.
  • 2024-07-18 08:29:40.433507116 +0000 UTC m=+515402.424448585: ☑️ agreed by nolouch.

@ti-chi-bot ti-chi-bot bot merged commit 0e5e9ee into pingcap:master Jul 18, 2024
23 checks passed
@JmPotato JmPotato deleted the update_rc branch July 18, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not disconnect if drop resource groups
3 participants