-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: support memTracker.detach for HashJoin, Apply and IndexLookUp in Close func #54095
Merged
Merged
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
30da2fc
*: support memTracker.detach for HashJoin, Apply and IndexLookUp in C…
XuHuaiyu 852892f
Merge branch 'master' of github.com:pingcap/tidb into issue54005
XuHuaiyu 63a79db
fix build
XuHuaiyu 40d6d21
fix build
XuHuaiyu 355de13
address comment
XuHuaiyu ecbe6b3
address comment
XuHuaiyu af6b2de
Merge branch 'master' of github.com:pingcap/tidb into issue54005
XuHuaiyu 0a502f4
fix test
XuHuaiyu 4798e96
Merge branch 'master' into issue54005
XuHuaiyu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,6 +45,18 @@ type RowPtr struct { | |
RowIdx uint32 | ||
} | ||
|
||
// NewListWithMemTracker creates a new List with field types, init chunk size, max chunk size and memory tracker. | ||
func NewListWithMemTracker(fieldTypes []*types.FieldType, initChunkSize, maxChunkSize int, tracker *memory.Tracker) *List { | ||
l := &List{ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe call |
||
fieldTypes: fieldTypes, | ||
initChunkSize: initChunkSize, | ||
maxChunkSize: maxChunkSize, | ||
memTracker: tracker, | ||
consumedIdx: -1, | ||
} | ||
return l | ||
} | ||
|
||
// NewList creates a new List with field types, init chunk size and max chunk size. | ||
func NewList(fieldTypes []*types.FieldType, initChunkSize, maxChunkSize int) *List { | ||
l := &List{ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move before
workerFinished