plan, executor: only set DefaultValues in agg push down. #5383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenli
reviewed
Dec 12, 2017
| e.outerExec = rightExec | ||
| e.innerFilter = v.LeftConditions | ||
| e.outerFilter = v.RightConditions | ||
| e.innerKeys = leftHashKey | ||
| e.outerKeys = rightHashKey | ||
| if defaultValues == nil { |
There was a problem hiding this comment.
Can we combine this code block with the code block in line 603~607?
shenli
reviewed
Dec 12, 2017
| @@ -158,9 +157,6 @@ func (pe *projectionEliminater) eliminate(p LogicalPlan, replace map[string]*exp | |||
| if !(isProj && canEliminate && canProjectionBeEliminatedLoose(proj)) { | |||
| return p | |||
| } | |||
| if join, ok := p.Parents()[0].(*LogicalJoin); ok { | |||
There was a problem hiding this comment.
@shenli projection elimination is done before aggregation push down, we can remove it safely.
|
LGTM |
zz-jason
reviewed
Dec 12, 2017
| @@ -158,9 +157,6 @@ func (pe *projectionEliminater) eliminate(p LogicalPlan, replace map[string]*exp | |||
| if !(isProj && canEliminate && canProjectionBeEliminatedLoose(proj)) { | |||
| return p | |||
| } | |||
| if join, ok := p.Parents()[0].(*LogicalJoin); ok { | |||
There was a problem hiding this comment.
@shenli projection elimination is done before aggregation push down, we can remove it safely.
plan/logical_plans.go
Outdated
| // instead of null padding. | ||
| // DefaultValues is only used for outer join, which is values the inner table's should be when the outer table | ||
| // doesn't match any inner table'row. | ||
| // That it's nil just means the default values is a slice of NULL. |
There was a problem hiding this comment.
how about:
// DefaultValues are only used for "LeftOuterJoin" and "RightOuterJoin" as the inner row when there is no inner row in the inner table can be joined with an outer row.
// NOTE: It is only set during the optimization of "aggregate push down", otherwise it will be nil, witch means a slice of NULLs.
coocood
reviewed
Dec 12, 2017
executor/builder.go
Outdated
| @@ -581,30 +581,24 @@ func (b *executorBuilder) buildHashJoin(v *plan.PhysicalHashJoin) Executor { | |||
| } | |||
|
|
|||
| defaultValues := v.DefaultValues | |||
| if defaultValues == nil { | |||
| defaultValues = make([]types.Datum, e.innerExec.Schema().Len()) | |||
|
/run-all-tests |
zz-jason
approved these changes
Dec 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5338 and fix #5278
PTAL @zz-jason @coocood @hanfei1991