-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: implement global goroutine pool (#53299) #53346
Conversation
Signed-off-by: you06 <you1474600@gmail.com> global gp demo Signed-off-by: you06 <you1474600@gmail.com> fmt code Signed-off-by: you06 <you1474600@gmail.com> add comment Signed-off-by: you06 <you1474600@gmail.com> add comment Signed-off-by: you06 <you1474600@gmail.com> add threshold for shared pool Signed-off-by: you06 <you1474600@gmail.com> comment code Signed-off-by: you06 <you1474600@gmail.com> close the global pool when kvstore is closed only Signed-off-by: you06 <you1474600@gmail.com> fmt code Signed-off-by: you06 <you1474600@gmail.com>
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @you06. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #53346 +/- ##
================================================
Coverage ? 71.1591%
================================================
Files ? 1466
Lines ? 421464
Branches ? 0
================================================
Hits ? 299910
Misses ? 101087
Partials ? 20467
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Close thie PR because we won't backport it to 8.1, supress the regression by #53429. |
cherry pick #53299 to release-8.1 branch
What problem does this PR solve?
Issue Number: close #52887
Problem Summary:
What changed and how does it work?
Goroutines with short lifetime often release its stack soon after several stack grows, this made
newstack
a performance issue. This PR create a global goroutine pool, reuse the stack, which shows a great improvement, high QPS with lower CPU utilization.Check List
Tests
Sysbench read only(with
--point-selects=0
)TPC-C
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.