Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: resolve panic when the update lists contain complex subquery #53108

Merged
merged 2 commits into from
May 9, 2024
Merged

planner: resolve panic when the update lists contain complex subquery #53108

merged 2 commits into from
May 9, 2024

Conversation

winoros
Copy link
Member

@winoros winoros commented May 8, 2024

What problem does this PR solve?

Issue Number: close #52687

Problem Summary:

What changed and how does it work?

When we meet the subqueries, we'll rewrite the structure of the plan tree. We need to find a way to represent the subqueries in the UPDATE's lists

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 8, 2024
@winoros
Copy link
Member Author

winoros commented May 8, 2024 •
edited
Loading

The initial round is to test whether the whole test can pass.

@codecov Codecov
Copy link

codecov bot commented May 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.3471%. Comparing base (81da4f8) to head (1ff38f6).
Report is 25 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #53108        +/-   ##
================================================
+ Coverage   72.0214%   74.3471%   +2.3256%     
================================================
  Files          1508       1510         +2     
  Lines        434823     441498      +6675     
================================================
+ Hits         313166     328241     +15075     
+ Misses       102084      93015      -9069     
- Partials      19573      20242       +669
Flag Coverage Δ
integration 49.5095% <100.0000%> (?)
unit 71.2455% <100.0000%> (+0.0179%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 46.8032% <ø> (+8.3261%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 8, 2024
@winoros
Copy link
Member Author

winoros commented May 8, 2024

/retest

time-and-fate
time-and-fate approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@time-and-fate time-and-fate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to simplify the test case.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 9, 2024
AilinKid
AilinKid reviewed May 9, 2024
View reviewed changes
tests/integrationtest/r/planner/core/issuetest/planner_issue.result
from
t_o9_7_f as ref_1
where (-9186514464458010455 <> 62.67)))),
c_if = 'u1ah7',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we show the explain result？

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 9, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-09 07:49:17.544528054 +0000 UTC m=+1121111.301663628: ☑️ agreed by time-and-fate.
  • 2024-05-09 09:46:37.228566316 +0000 UTC m=+1128150.985701888: ☑️ agreed by AilinKid.

@winoros
Copy link
Member Author

winoros commented May 9, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 97d4705 into pingcap:master May 9, 2024
22 of 23 checks passed
@winoros
Copy link
Member Author

winoros commented May 9, 2024

/cherrypick release-8.1

@winoros winoros deleted the try-to-fix-updatelists branch May 9, 2024 15:24
@ti-chi-bot ti-chi-bot mentioned this pull request May 9, 2024
Merged
13 tasks
@ti-chi-bot
Copy link
Member

@winoros: new pull request created to branch release-8.1: #53144.

In response to this:

/cherrypick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request May 10, 2024
@ti-chi-bot
planner: resolve panic when the update lists contain complex subquery (…
fe1f6ca 
…#53108) (#53144)

close #52687
@winoros
Copy link
Member Author

winoros commented May 14, 2024

/cherrypick release-7.5
/cherrypick release-7.1
/cherrypick release-6.5

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 14, 2024
@winoros @ti-chi-bot
This is an automated cherry-pick of pingcap#53108
5b1e5dc 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

@winoros: new pull request created to branch release-6.5: #53269.

In response to this:

/cherrypick release-7.5
/cherrypick release-7.1
/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request May 14, 2024
Merged
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 14, 2024
@winoros @ti-chi-bot
This is an automated cherry-pick of pingcap#53108
09a4c09 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 14, 2024
Open
13 tasks
@ti-chi-bot
Copy link
Member

@winoros: new pull request created to branch release-7.1: #53270.

In response to this:

/cherrypick release-7.5
/cherrypick release-7.1
/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 14, 2024
@winoros @ti-chi-bot
This is an automated cherry-pick of pingcap#53108
63567df 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 14, 2024
Merged
13 tasks
@ti-chi-bot
Copy link
Member

@winoros: new pull request created to branch release-7.5: #53271.

In response to this:

/cherrypick release-7.5
/cherrypick release-7.1
/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

terry1purcell pushed a commit to terry1purcell/tidb that referenced this pull request May 17, 2024
@winoros @terry1purcell
planner: resolve panic when the update lists contain complex subquery (…
91a3d58 
…pingcap#53108)

close pingcap#52687
ti-chi-bot bot pushed a commit that referenced this pull request May 21, 2024
@ti-chi-bot
planner: resolve panic when the update lists contain complex subquery (…
4b80634 
…#53108) (#53271)

close #52687
RidRisR pushed a commit to RidRisR/tidb that referenced this pull request May 23, 2024
@winoros @RidRisR
planner: resolve panic when the update lists contain complex subquery (…
721bd9d 
…pingcap#53108)

close pingcap#52687
ti-chi-bot bot pushed a commit that referenced this pull request Jun 9, 2024
@ti-chi-bot
planner: resolve panic when the update lists contain complex subquery (…
b4f3a10 
…#53108) (#53269)

close #52687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TiDB panics on complex query
4 participants
@winoros @ti-chi-bot @AilinKid @time-and-fate