Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: clean the one side filters for outer join reorder which is not done in #44409 (#45565) #53074

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #45565

What problem does this PR solve?

Issue Number: close #45564 , ref #44409

Problem Summary:

What is changed and how it works?

In #44409 , we only cleaned the other conditions, but the one side filters will also need to be checked.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the case that the join predicates might be put in the wrong place.

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-6.5-20230625-v6.5.3 labels May 7, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@elsa0520 elsa0520 force-pushed the cherry-pick-45565-to-release-6.5-20230625-v6.5.3 branch from 7279b9e to 7a542f5 Compare May 7, 2024 07:47
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels May 7, 2024
Copy link
Contributor

@elsa0520 elsa0520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label May 7, 2024
Copy link

ti-chi-bot bot commented May 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elsa0520, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 7, 2024
Copy link

ti-chi-bot bot commented May 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-07 07:49:20.372852857 +0000 UTC m=+948314.129988428: ☑️ agreed by winoros.
  • 2024-05-07 08:03:26.234069546 +0000 UTC m=+949159.991205116: ☑️ agreed by elsa0520.

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-6.5-20230625-v6.5.3@5e74466). Click here to learn what that means.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             release-6.5-20230625-v6.5.3     #53074   +/-   ##
================================================================
  Coverage                               ?   73.4092%           
================================================================
  Files                                  ?       1080           
  Lines                                  ?     346463           
  Branches                               ?          0           
================================================================
  Hits                                   ?     254336           
  Misses                                 ?      75689           
  Partials                               ?      16438           

@ti-chi-bot ti-chi-bot bot merged commit 0e4da39 into pingcap:release-6.5-20230625-v6.5.3 May 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-6.5-20230625-v6.5.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants