-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lightning: add retry if transaction failed while fetching task metas #53041
base: release-7.5
Are you sure you want to change the base?
Lightning: add retry if transaction failed while fetching task metas #53041
Conversation
…il confirm with PingCap. (pingcap#67) This is to unblock release-7.5.1 PR ci. Co-authored-by: Hao Wang <hwang4@airbnb.com>
…ingcap#64) close pingcap#52049 Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
…pingcap#51449) (pingcap#51) (pingcap#63) close pingcap#51448 Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
…) (pingcap#48) (pingcap#62) close pingcap#51957 Co-authored-by: Naman Gupta <naman.gupta@airbnb.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
…#51371) (pingcap#46) (pingcap#61) close pingcap#51370 Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
Co-authored-by: artem_danilov <artem_danilov@airbnb.com>
Co-authored-by: rishabh_mittal <mittalrishabh@gmail.com>
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @mittalrishabh. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hao Wang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What problem does this PR solve?
Issue Number: close 53042
Problem Summary:
The transaction may encounter an error message stating "Error 1205: Lock wait timeout exceeded; try restarting transaction". This error can cause the import job to fail. The import job does not always start from the checkpoint, as it depends on the stage at which the failure occurred. If the transaction fails after the import/ingestion is completed, the job will not start from the checkpoint. As a result, the entire bulk load job needs to be restarted, which is a costly operation and can potentially violate our SLOs.
What changed and how does it work?
Add retry with back off if transaction fails. It is going to retry up to 5 times with maxbackoff of 30 seconds and baseline backoff of 1 second.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.