Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: update manual of integration tests #52689

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

RidRisR
Copy link
Contributor

@RidRisR RidRisR commented Apr 18, 2024

What problem does this PR solve?

Issue Number: close #52690

Problem Summary:

Update the manual of integration tests

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Apr 18, 2024
Copy link

tiprow bot commented Apr 18, 2024

Hi @RidRisR. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 18, 2024
@lance6716
Copy link
Contributor

/check-issue-triage-complete

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Merging #52689 (b334ddd) into master (53c050b) will increase coverage by 2.1399%.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52689        +/-   ##
================================================
+ Coverage   70.8415%   72.9815%   +2.1399%     
================================================
  Files          1471       1471                
  Lines        408719     425372     +16653     
================================================
+ Hits         289543     310443     +20900     
+ Misses        99970      94750      -5220     
- Partials      19206      20179       +973     
Flag Coverage Δ
integration 50.4432% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 56.2971% <ø> (ø)
parser ∅ <ø> (∅)
br 58.6450% <ø> (+15.9858%) ⬆️

Copy link

ti-chi-bot bot commented Apr 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 18, 2024
Copy link

ti-chi-bot bot commented Apr 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-18 01:19:17.549979546 +0000 UTC m=+473776.661025995: ☑️ agreed by YuJuncen.
  • 2024-04-18 02:25:00.369445941 +0000 UTC m=+477719.480492387: ☑️ agreed by Leavrth.

@ti-chi-bot ti-chi-bot bot merged commit f4e0d58 into pingcap:master Apr 18, 2024
22 of 24 checks passed
RidRisR added a commit to RidRisR/tidb that referenced this pull request Apr 18, 2024
@RidRisR RidRisR deleted the manual branch November 26, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manual of br integration tests is outdated
4 participants