Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plan, executor: remvove hasGby field. #5265

Merged
merged 2 commits into from
Nov 30, 2017
Merged

plan, executor: remvove hasGby field. #5265

merged 2 commits into from
Nov 30, 2017

Conversation

hanfei1991
Copy link
Member

No description provided.

winoros
winoros reviewed Nov 29, 2017
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenli
Copy link
Member

shenli commented Nov 29, 2017

LGTM

@shenli
Copy link
Member

shenli commented Nov 29, 2017

/run-all-tests

@zz-jason zz-jason changed the title plan, executor: remvove hasAgg field. plan, executor: remvove hasGby field. Nov 30, 2017
@zz-jason
Copy link
Member

/run-all-tests

@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 30, 2017
@zimulala zimulala merged commit db270fc into pingcap:master Nov 30, 2017
@hanfei1991 hanfei1991 deleted the agg branch November 30, 2017 03:50
@CalvinNeo CalvinNeo mentioned this pull request Aug 17, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hanfei1991 @shenli @zz-jason @zimulala @winoros