Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: remove the limitation that predicates can't be pushed through Projection on TableDual (#51329) #52164

Merged

Conversation

time-and-fate
Copy link
Member

@time-and-fate time-and-fate commented Mar 27, 2024

Manual cherry-pick #51329

What problem does this PR solve?

Issue Number: close #50614

Problem Summary:

#35669 disables predicates pushdown on TableDual.
This usually won't cause problems, but when it comes to cases like #50614, many unnecessary predicates with lots of conditions will cause obvious performance regression.

What changed and how does it work?

This PR reverts #35669, which is for fixing #35527.
#35527 itself has already been fixed by #38802, which prevents predicates from being incorrectly pushed through Projection.

As said in #35669, sometimes TableDual doesn't have a schema. This may or may not be considered as a mistake depending on our definition of the semantic of TableDual.
Anyway, TableDual without schema should not cause a problem if the predicates are pushed down correctly.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 27, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1@ca6a857). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #52164   +/-   ##
================================================
  Coverage               ?   73.4313%           
================================================
  Files                  ?       1212           
  Lines                  ?     379730           
  Branches               ?          0           
================================================
  Hits                   ?     278841           
  Misses                 ?      83069           
  Partials               ?      17820           

Copy link

ti-chi-bot bot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 28, 2024
Copy link

ti-chi-bot bot commented Mar 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-27 14:00:16.13382113 +0000 UTC m=+2076443.156067520: ☑️ agreed by winoros.
  • 2024-03-28 08:22:13.625270772 +0000 UTC m=+2142560.647517160: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot merged commit d3e6a29 into pingcap:release-7.1 Mar 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants