Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: handle the corner case that temp index is not exist but the normal index is exist (#51862) #52039

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #51862

What problem does this PR solve?

Issue Number: close #51784

Problem Summary:
If the temp index is not exist, we need to check if the normal index is exist.
The corner case is showed in the added unit test.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix a bug may cause unique index and data inconsistent when using insert ignore

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.0 labels Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-8.0@83651da). Click here to learn what that means.
The diff coverage is 60.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.0     #52039   +/-   ##
================================================
  Coverage               ?   70.6563%           
================================================
  Files                  ?       1477           
  Lines                  ?     438350           
  Branches               ?          0           
================================================
  Hits                   ?     309722           
  Misses                 ?     109164           
  Partials               ?      19464           
Flag Coverage Δ
unit 70.4427% <60.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 45.8085% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 23, 2024
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Mar 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 23, 2024
Copy link

ti-chi-bot bot commented Mar 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-23 05:57:52.790221722 +0000 UTC m=+1701899.812468102: ☑️ agreed by tangenta.
  • 2024-03-23 08:00:23.685973187 +0000 UTC m=+1709250.708219575: ☑️ agreed by Benjamin2037.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 25, 2024
@ti-chi-bot ti-chi-bot bot merged commit ef34ae2 into pingcap:release-8.0 Mar 25, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants