Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: upgrade PD client to fix another TSO hang bug #51952

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Mar 20, 2024

What problem does this PR solve?

Issue Number: close #51894, close tikv/pd#7849.

Problem Summary: upgrade PD client to fix another bug that may cause the TSO to hang during the PD service mode switch, see tikv/client-go#1241 and tikv/pd#7951.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 20, 2024
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Merging #51952 (bc096f2) into master (e25fb18) will decrease coverage by 15.9295%.
Report is 6 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #51952         +/-   ##
=================================================
- Coverage   70.6646%   54.7352%   -15.9295%     
=================================================
  Files          1477       1588        +111     
  Lines        438720     610048     +171328     
=================================================
+ Hits         310020     333911      +23891     
- Misses       109181     252935     +143754     
- Partials      19519      23202       +3683     
Flag Coverage Δ
integration 36.6452% <ø> (?)
unit 70.4748% <ø> (+0.0223%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.4361% <ø> (+5.6486%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 20, 2024
Copy link

ti-chi-bot bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CabinfeverB, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 20, 2024
Copy link

ti-chi-bot bot commented Mar 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-20 10:02:37.600891772 +0000 UTC m=+1457384.623138153: ☑️ agreed by zimulala.
  • 2024-03-20 10:03:39.344336192 +0000 UTC m=+1457446.366582580: ☑️ agreed by CabinfeverB.

@ti-chi-bot ti-chi-bot bot merged commit 93b96e9 into pingcap:master Mar 20, 2024
23 checks passed
@JmPotato JmPotato deleted the fix_tso_hang branch March 20, 2024 12:56
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Apr 18, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #52709.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 18, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot removed the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
4 participants