Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: some preallocation for slice #5180

Merged
merged 3 commits into from
Nov 22, 2017
Merged

*: some preallocation for slice #5180

merged 3 commits into from
Nov 22, 2017

Conversation

tshqin
Copy link
Contributor

@tshqin tshqin commented Nov 21, 2017

pre-allocating updates.
PTAL @coocood @hanfei1991

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2017

CLA assistant check
All committers have signed the CLA.

@winoros winoros changed the title pre-allocatings *: preallocate space for slice Nov 21, 2017
@winoros winoros changed the title *: preallocate space for slice *: some preallocation for slice Nov 21, 2017
Copy link
Member

@shenli shenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

pre-commit Outdated
@@ -0,0 +1 @@
hooks/pre-commit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my fault, no need for this file

@coocood
Copy link
Member

coocood commented Nov 22, 2017

LGTM

Copy link
Member

@ngaut ngaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngaut ngaut merged commit 4d09087 into pingcap:master Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants