prepare_snap: establish connection to all stores before pausing admin (#51449) #51730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yu Juncen <yu745514916@live.com>
ti-chi-bot
added
ok-to-test
5 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #51730 +/- ##
================================================
Coverage ? 73.6359%
================================================
Files ? 1095
Lines ? 350932
Branches ? 0
================================================
Hits ? 258412
Misses ? 75907
Partials ? 16613 |
YuJuncen
approved these changes
Mar 13, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
Signed-off-by: Yu Juncen <yu745514916@live.com>
|
@BornChanger : Did the BR integration tests pass. I see a hold. |
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
I just unhold it. There is another enhancement. |
ti-chi-bot
added
the
cherry-pick-approved
|
Maybe also pick #51823 here. |
BornChanger
approved these changes
Mar 25, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
13 tasks
13 tasks
mittalrishabh
pushed a commit
to mittalrishabh/tidb
that referenced
this pull request
May 30, 2024
…pingcap#51449) (pingcap#51730) (pingcap#86) close pingcap#51448 Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #51449
What problem does this PR solve?
Issue Number: close #51448
Problem Summary:
Now if we cannot connect to a TiKV, it will block at creating connection.
But, in this scenario, some of TiKVs' admin commands are paused. That will impact the TP workload more.
What changed and how does it work?
After this PR, we won't pause the admin commands before connections to all TiKV nodes established.
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.