Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support reading historial data for infoschema v2 #51681

Merged
merged 9 commits into from
Mar 13, 2024

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #51679, ref #50959

Problem Summary:

What changed and how does it work?

Use schema ts instead of math.MaxUint64 for infoschemaV2

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 12, 2024
@tiancaiamao tiancaiamao requested a review from ywqzzy March 12, 2024 04:07
@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 12, 2024
Copy link

tiprow bot commented Mar 12, 2024

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Merging #51681 (3dd3fd8) into master (0d742d3) will increase coverage by 0.3722%.
Report is 4 commits behind head on master.
The diff coverage is 94.5454%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51681        +/-   ##
================================================
+ Coverage   72.4732%   72.8454%   +0.3722%     
================================================
  Files          1475       1475                
  Lines        363671     438534     +74863     
================================================
+ Hits         263564     319452     +55888     
- Misses        80719      99090     +18371     
- Partials      19388      19992       +604     
Flag Coverage Δ
integration 48.8956% <36.3636%> (?)
unit 70.5480% <94.5454%> (-1.8157%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 51.6364% <ø> (+5.2271%) ⬆️

Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 13, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 13, 2024
MODULE.bazel.lock Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 13, 2024
Copy link

ti-chi-bot bot commented Mar 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-13 04:11:49.863376264 +0000 UTC m=+831536.885622649: ☑️ agreed by GMHDBJD.
  • 2024-03-13 05:22:39.087038693 +0000 UTC m=+835786.109285081: ☑️ agreed by ywqzzy.

Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Mar 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, GMHDBJD, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 13, 2024
@tiancaiamao
Copy link
Contributor Author

/test unit-test

Copy link

tiprow bot commented Mar 13, 2024

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 893104a into pingcap:master Mar 13, 2024
25 checks passed
@tiancaiamao tiancaiamao deleted the historial-read branch March 13, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support snapshot infoschema for historial read and stale read
4 participants