Skip to content

planner: allow the optimizer to cache query plans accessing generated columns by default#51654

Merged
ti-chi-bot[bot] merged 4 commits into
pingcap:masterfrom
qw4990:plan-cache-mvindex
Mar 11, 2024
Merged

planner: allow the optimizer to cache query plans accessing generated columns by default#51654
ti-chi-bot[bot] merged 4 commits into
pingcap:masterfrom
qw4990:plan-cache-mvindex

Conversation

@qw4990

@qw4990 qw4990 commented Mar 11, 2024

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #45798

Problem Summary: planner: allow the optimizer to cache query plans accessing generated columns by default

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 11, 2024
@tiprow

tiprow Bot commented Mar 11, 2024

Copy link
Copy Markdown

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov

codecov Bot commented Mar 11, 2024

Copy link
Copy Markdown

Codecov Report

Merging #51654 (d128ef4) into master (caf83ed) will increase coverage by 2.1210%.
Report is 3 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51654        +/-   ##
================================================
+ Coverage   70.7306%   72.8516%   +2.1210%     
================================================
  Files          1473       1473                
  Lines        437092     437353       +261     
================================================
+ Hits         309158     318619      +9461     
+ Misses       108562      98747      -9815     
- Partials      19372      19987       +615     
Flag Coverage Δ
integration 48.8645% <66.6666%> (?)
unit 70.5260% <100.0000%> (-0.0081%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.4350% <ø> (+5.5603%) ⬆️

Comment thread pkg/planner/core/plan_cacheable_checker.go Outdated
@ti-chi-bot ti-chi-bot Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 11, 2024
@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 11, 2024
@qw4990

qw4990 commented Mar 11, 2024

Copy link
Copy Markdown
Contributor Author

/retest

@tiprow

tiprow Bot commented Mar 11, 2024

Copy link
Copy Markdown

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot

ti-chi-bot Bot commented Mar 11, 2024

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [AilinKid,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 11, 2024
@ti-chi-bot

ti-chi-bot Bot commented Mar 11, 2024

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2024-03-11 09:25:21.558587869 +0000 UTC m=+677548.580834253: ☑️ agreed by AilinKid.
  • 2024-03-11 09:54:25.338331777 +0000 UTC m=+679292.360578165: ☑️ agreed by hawkingrei.

@qw4990

qw4990 commented Mar 11, 2024

Copy link
Copy Markdown
Contributor Author

/test unit-test

@tiprow

tiprow Bot commented Mar 11, 2024

Copy link
Copy Markdown

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot Bot merged commit f2cbe00 into pingcap:master Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

planner: allow the optimizer to cache query plans accessing generated columns

3 participants