Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ttl: fix TTL cannot split tasks with right ranges for common handle int #51532

Merged
merged 2 commits into from
Mar 6, 2024
Merged

ttl: fix TTL cannot split tasks with right ranges for common handle int #51532

merged 2 commits into from
Mar 6, 2024

Conversation

lcwangchao
Copy link
Collaborator

@lcwangchao lcwangchao commented Mar 6, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #51527

What changed and how does it work?

If a table has a primary key with common handle, we should use kv.CommonHanlde to decode the region edges even if the row type is integer.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

I tested this PR by re-execute the SQL in the issue, all tasks have rows to delete:

> select * from mysql.tidb_ttl_task;
+----------------------------------+----------+---------+----------------------+----------------------+---------------------+--------------------------------------+------------+---------------------+----------+---------------------+-------------------------------------------------------------------------------+---------------------+
| job_id                           | table_id | scan_id | scan_range_start     | scan_range_end       | expire_time         | owner_id                             | owner_addr | owner_hb_time       | status   | status_update_time  | state                                                                         | created_time        |
+----------------------------------+----------+---------+----------------------+----------------------+---------------------+--------------------------------------+------------+---------------------+----------+---------------------+-------------------------------------------------------------------------------+---------------------+
| 36d048f06f08429cbe83d37ace4a762e | 237      | 0       |                      | 0x0381fffffffffffffe | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":130835,"success_rows":130835,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 1       | 0x0381fffffffffffffe | 0x0383fffffffffffffc | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":131412,"success_rows":131412,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 2       | 0x0383fffffffffffffc | 0x0385fffffffffffffa | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":130290,"success_rows":130290,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 3       | 0x0385fffffffffffffa | 0x0387fffffffffffff8 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":130442,"success_rows":130442,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 4       | 0x0387fffffffffffff8 | 0x0389fffffffffffff6 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":131202,"success_rows":131202,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 5       | 0x0389fffffffffffff6 | 0x038bfffffffffffff4 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":130936,"success_rows":130936,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 6       | 0x038bfffffffffffff4 | 0x038dfffffffffffff2 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":131376,"success_rows":131376,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 7       | 0x038dfffffffffffff2 | 0x038ffffffffffffff0 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":131395,"success_rows":131395,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 8       | 0x038ffffffffffffff0 | 0x0391ffffffffffffee | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:45 | {"total_rows":131395,"success_rows":131395,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 9       | 0x0391ffffffffffffee | 0x0393ffffffffffffec | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:45 | {"total_rows":130649,"success_rows":130649,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 10      | 0x0393ffffffffffffec | 0x0395ffffffffffffea | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":131319,"success_rows":131319,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 11      | 0x0395ffffffffffffea | 0x0397ffffffffffffe8 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":131719,"success_rows":131719,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 12      | 0x0397ffffffffffffe8 | 0x0399ffffffffffffe6 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":131401,"success_rows":131401,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 13      | 0x0399ffffffffffffe6 | 0x039bffffffffffffe4 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:45 | {"total_rows":131173,"success_rows":131173,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 14      | 0x039bffffffffffffe4 | 0x039dffffffffffffe2 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:45 | {"total_rows":130445,"success_rows":130445,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 15      | 0x039dffffffffffffe2 | 0x039fffffffffffffe0 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":131003,"success_rows":131003,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 16      | 0x039fffffffffffffe0 | 0x03a1ffffffffffffde | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":131638,"success_rows":131638,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 17      | 0x03a1ffffffffffffde | 0x03a3ffffffffffffdc | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:45 | {"total_rows":130686,"success_rows":130686,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 18      | 0x03a3ffffffffffffdc | 0x03a5ffffffffffffda | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":131369,"success_rows":131369,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 19      | 0x03a5ffffffffffffda | 0x03a7ffffffffffffd8 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:45 | {"total_rows":130468,"success_rows":130468,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 20      | 0x03a7ffffffffffffd8 | 0x03a9ffffffffffffd6 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":131092,"success_rows":131092,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 21      | 0x03a9ffffffffffffd6 | 0x03abffffffffffffd4 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":130686,"success_rows":130686,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 22      | 0x03abffffffffffffd4 | 0x03adffffffffffffd2 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":131660,"success_rows":131660,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 23      | 0x03adffffffffffffd2 | 0x03afffffffffffffd0 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":131411,"success_rows":131411,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 24      | 0x03afffffffffffffd0 | 0x03b1ffffffffffffce | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":131106,"success_rows":131106,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 25      | 0x03b1ffffffffffffce | 0x03b3ffffffffffffcc | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":130604,"success_rows":130604,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 26      | 0x03b3ffffffffffffcc | 0x03b5ffffffffffffca | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":130804,"success_rows":130804,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 27      | 0x03b5ffffffffffffca | 0x03b7ffffffffffffc8 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":130563,"success_rows":130563,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 28      | 0x03b7ffffffffffffc8 | 0x03b9ffffffffffffc6 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:45 | {"total_rows":131006,"success_rows":131006,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 29      | 0x03b9ffffffffffffc6 | 0x03bbffffffffffffc4 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":131228,"success_rows":131228,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 30      | 0x03bbffffffffffffc4 | 0x03bdffffffffffffc2 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":130973,"success_rows":130973,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 31      | 0x03bdffffffffffffc2 | 0x03bfffffffffffffc0 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":131695,"success_rows":131695,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 32      | 0x03bfffffffffffffc0 | 0x03c1ffffffffffffbe | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":131012,"success_rows":131012,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 33      | 0x03c1ffffffffffffbe | 0x03c3ffffffffffffbc | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":131601,"success_rows":131601,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 34      | 0x03c3ffffffffffffbc | 0x03c5ffffffffffffba | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":130959,"success_rows":130959,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 35      | 0x03c5ffffffffffffba | 0x03c7ffffffffffffb8 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:45 | {"total_rows":131740,"success_rows":131740,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 36      | 0x03c7ffffffffffffb8 | 0x03c9ffffffffffffb6 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":131481,"success_rows":131481,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 37      | 0x03c9ffffffffffffb6 | 0x03cbffffffffffffb4 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":130549,"success_rows":130549,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 38      | 0x03cbffffffffffffb4 | 0x03cdffffffffffffb2 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:45 | {"total_rows":130535,"success_rows":130535,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 39      | 0x03cdffffffffffffb2 | 0x03cfffffffffffffb0 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":131374,"success_rows":131374,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 40      | 0x03cfffffffffffffb0 | 0x03d1ffffffffffffae | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":131365,"success_rows":131365,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 41      | 0x03d1ffffffffffffae | 0x03d3ffffffffffffac | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":131532,"success_rows":131532,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 42      | 0x03d3ffffffffffffac | 0x03d5ffffffffffffaa | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":131912,"success_rows":131912,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 43      | 0x03d5ffffffffffffaa | 0x03d7ffffffffffffa8 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":130633,"success_rows":130633,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 44      | 0x03d7ffffffffffffa8 | 0x03d9ffffffffffffa6 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":130357,"success_rows":130357,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 45      | 0x03d9ffffffffffffa6 | 0x03dbffffffffffffa4 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:45 | {"total_rows":131045,"success_rows":131045,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 46      | 0x03dbffffffffffffa4 | 0x03ddffffffffffffa2 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":130127,"success_rows":130127,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 47      | 0x03ddffffffffffffa2 | 0x03dfffffffffffffa0 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":130713,"success_rows":130713,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 48      | 0x03dfffffffffffffa0 | 0x03e1ffffffffffff9e | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":131140,"success_rows":131140,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 49      | 0x03e1ffffffffffff9e | 0x03e3ffffffffffff9c | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":130811,"success_rows":130811,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 50      | 0x03e3ffffffffffff9c | 0x03e5ffffffffffff9a | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:45 | {"total_rows":130923,"success_rows":130923,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 51      | 0x03e5ffffffffffff9a | 0x03e7ffffffffffff98 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":130837,"success_rows":130837,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 52      | 0x03e7ffffffffffff98 | 0x03e9ffffffffffff96 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":131847,"success_rows":131847,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 53      | 0x03e9ffffffffffff96 | 0x03ebffffffffffff94 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:45 | {"total_rows":131362,"success_rows":131362,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 54      | 0x03ebffffffffffff94 | 0x03edffffffffffff92 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":130965,"success_rows":130965,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 55      | 0x03edffffffffffff92 | 0x03efffffffffffff90 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":131766,"success_rows":131766,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 56      | 0x03efffffffffffff90 | 0x03f1ffffffffffff8e | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":131362,"success_rows":131362,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 57      | 0x03f1ffffffffffff8e | 0x03f3ffffffffffff8c | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":131127,"success_rows":131127,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 58      | 0x03f3ffffffffffff8c | 0x03f5ffffffffffff8a | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":130792,"success_rows":130792,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 59      | 0x03f5ffffffffffff8a | 0x03f7ffffffffffff88 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":130487,"success_rows":130487,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 60      | 0x03f7ffffffffffff88 | 0x03f9ffffffffffff86 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":130728,"success_rows":130728,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 61      | 0x03f9ffffffffffff86 | 0x03fbffffffffffff84 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":131254,"success_rows":131254,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 62      | 0x03fbffffffffffff84 | 0x03fdffffffffffff82 | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":130753,"success_rows":130753,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
| 36d048f06f08429cbe83d37ace4a762e | 237      | 63      | 0x03fdffffffffffff82 |                      | 2024-03-06 13:47:39 | e22f0d32-883c-4512-88ca-c9199eb4fe44 | <null>     | 2024-03-06 13:53:25 | finished | 2024-03-06 13:53:50 | {"total_rows":131538,"success_rows":131538,"error_rows":0,"scan_task_err":""} | 2024-03-06 13:48:40 |
+----------------------------------+----------+---------+----------------------+----------------------+---------------------+--------------------------------------+------------+---------------------+----------+---------------------+-------------------------------------------------------------------------------+---------------------+
64 rows in set
Time: 0.017s
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix TTL cannot split tasks with right ranges for common handle int

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 6, 2024
@tiprow tiprow
Copy link

tiprow bot commented Mar 6, 2024

Hi @lcwangchao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov Codecov
Copy link

codecov bot commented Mar 6, 2024 •
edited
Loading

Codecov Report

Merging #51532 (d73fc61) into master (ad28e23) will increase coverage by 2.0577%.
Report is 5 commits behind head on master.
The diff coverage is 82.7160%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #51532        +/-   ##
================================================
+ Coverage   70.7750%   72.8328%   +2.0577%     
================================================
  Files          1464       1464                
  Lines        435573     436604      +1031     
================================================
+ Hits         308277     317991      +9714     
+ Misses       108013      98633      -9380     
- Partials      19283      19980       +697
Flag Coverage Δ
integration 48.8301% <11.1111%> (?)
unit 70.5161% <82.7160%> (-0.0550%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.4671% <ø> (+5.5477%) ⬆️

Defined2014
Defined2014 reviewed Mar 6, 2024
View reviewed changes
pkg/ttl/cache/table.go Outdated Show resolved Hide resolved
pkg/ttl/cache/split_test.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 6, 2024
@lcwangchao lcwangchao added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Mar 6, 2024
YangKeao
YangKeao approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,YangKeao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 6, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-06 08:01:27.696165404 +0000 UTC m=+240514.718411784: ☑️ agreed by Defined2014.
  • 2024-03-06 08:38:39.524550741 +0000 UTC m=+242746.546797129: ☑️ agreed by YangKeao.

@ti-chi-bot ti-chi-bot bot merged commit dd1c635 into pingcap:master Mar 6, 2024
23 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 6, 2024
@lcwangchao @ti-chi-bot
This is an automated cherry-pick of pingcap#51532
fdaafeb 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 6, 2024
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #51544.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #51545.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 6, 2024
@lcwangchao @ti-chi-bot
This is an automated cherry-pick of pingcap#51532
9ca5c61 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 6, 2024
Merged
13 tasks
@lcwangchao lcwangchao deleted the fix_51527 branch March 6, 2024 09:50
ti-chi-bot bot pushed a commit that referenced this pull request Mar 6, 2024
@ti-chi-bot
ttl: fix TTL cannot split tasks with right ranges for common handle i…
f76c6ac 
…nt (#51532) (#51545)

close #51527
@ti-chi-bot ti-chi-bot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 13, 2024
@ti-chi-bot ti-chi-bot bot removed the release-note-none Denotes a PR that doesn't merit a release note. label Mar 13, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Mar 13, 2024
@ti-chi-bot
ttl: fix TTL cannot split tasks with right ranges for common handle i…
944eeae 
…nt (#51532) (#51544)

close #51527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangKeao YangKeao YangKeao approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The task ranges of TTL are not even for common handle with a int column
4 participants
@lcwangchao @ti-chi-bot @YangKeao @Defined2014