Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/golangci/golangci-lint from 1.56.1 to 1.56.2 #51444

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 1, 2024

Bumps github.com/golangci/golangci-lint from 1.56.1 to 1.56.2.

Release notes

Sourced from github.com/golangci/golangci-lint's releases.

v1.56.2

golangci-lint is a free and open-source project, built by people in their free time. Also, the linter authors are an important part of golangci-lint. If you use and appreciate golangci-lint please think to support us (golangci-lint maintainers and linters authors). ❤️

Changelog

  • 6f268403 build(deps): bump github.com/Antonboom/testifylint from 1.1.1 to 1.1.2 (#4371)
  • 5a78c8a0 build(deps): bump github.com/bombsimon/wsl/v4 from 4.2.0 to 4.2.1 (#4367)
  • 71eae84b build(deps): bump github.com/go-critic/go-critic from 0.11.0 to 0.11.1 (#4388)
  • 58a724a0 build(deps): bump github.com/sashamelentyev/usestdlibvars from 1.24.0 to 1.25.0 (#4390)
  • a35de8c6 build(deps): bump github.com/securego/gosec/v2 from 2.18.2 to 2.19.0 (#4389)
  • 21bb5432 build(deps): bump golang.org/x/oauth2 from 0.16.0 to 0.17.0 in /scripts/gen_github_action_config (#4380)
  • 5513d3c9 build(deps): bump golang.org/x/tools from 0.17.0 to 0.18.0 (#4387)
  • 53578856 build(deps): bump golangci/golangci-lint-action from 3.7.0 to 4.0.0 (#4379)
Changelog

Sourced from github.com/golangci/golangci-lint's changelog.

v1.56.2

  1. updated linters
    • go-critic: from 0.11.0 to 0.11.1
    • gosec: from 2.18.2 to 2.19.0
    • testifylint: from 1.1.1 to 1.1.2
    • usestdlibvars: from 1.24.0 to 1.25.0
    • wsl: from 4.2.0 to 4.2.1
  2. misc.
    • Fix missing version in Docker image
  3. Documentation
    • Explain the limitation of new-from-rev and new-from-patch
Commits
  • 58a724a build(deps): bump github.com/sashamelentyev/usestdlibvars from 1.24.0 to 1.25...
  • a35de8c build(deps): bump github.com/securego/gosec/v2 from 2.18.2 to 2.19.0 (#4389)
  • 71eae84 build(deps): bump github.com/go-critic/go-critic from 0.11.0 to 0.11.1 (#4388)
  • 5513d3c build(deps): bump golang.org/x/tools from 0.17.0 to 0.18.0 (#4387)
  • 21bb543 build(deps): bump golang.org/x/oauth2 from 0.16.0 to 0.17.0 in /scripts/gen_g...
  • 5357885 build(deps): bump golangci/golangci-lint-action from 3.7.0 to 4.0.0 (#4379)
  • 403437e docs: explain limitation of new-from-rev and new-from-patch (#4377)
  • bf5008a dev: handle old TODO (#4374)
  • cc3e67b dev: fix govet.nilness lint issues (#4373)
  • 7cf6cc9 dev: refactor govet impl with slices.Contains (#4372)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

What problem does this PR solve?

Issue Number: ref None
Problem Summary: planner: simplify the session binding handler code

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.56.1 to 1.56.2.
- [Release notes](https://github.com/golangci/golangci-lint/releases)
- [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md)
- [Commits](golangci/golangci-lint@v1.56.1...v1.56.2)

---
updated-dependencies:
- dependency-name: github.com/golangci/golangci-lint
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Mar 1, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 1, 2024
Copy link

ti-chi-bot bot commented Mar 1, 2024

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

tiprow bot commented Mar 1, 2024

Hi @dependabot[bot]. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Mar 1, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 1, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 1, 2024
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-tests-checked do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 1, 2024
@hawkingrei hawkingrei added the skip-issue-check Indicates that a PR no need to check linked issue. label Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Merging #51444 (08d05b5) into master (8e29115) will increase coverage by 2.0716%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51444        +/-   ##
================================================
+ Coverage   70.6939%   72.7655%   +2.0716%     
================================================
  Files          1462       1462                
  Lines        435224     435867       +643     
================================================
+ Hits         307677     317161      +9484     
+ Misses       108246      98774      -9472     
- Partials      19301      19932       +631     
Flag Coverage Δ
integration 49.0651% <ø> (?)
unit 70.4383% <ø> (-0.0554%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.4330% <ø> (+5.5865%) ⬆️

@lance6716
Copy link
Contributor

/retest

1 similar comment
@hawkingrei
Copy link
Member

/retest

Copy link

ti-chi-bot bot commented Mar 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 1, 2024
@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 1, 2024
Copy link

ti-chi-bot bot commented Mar 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-01 04:53:28.677400118 +0000 UTC m=+1196897.425023214: ☑️ agreed by hawkingrei.
  • 2024-03-01 07:02:59.598186568 +0000 UTC m=+1204668.345809680: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit df527fe into master Mar 1, 2024
22 of 23 checks passed
@ti-chi-bot ti-chi-bot bot deleted the dependabot/go_modules/github.com/golangci/golangci-lint-1.56.2 branch March 1, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dependencies Pull requests that update a dependency file lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants