-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix BatchPoint
leads to tidb panic when KeyPartition column is part of multi-column index
#51315
executor: fix BatchPoint
leads to tidb panic when KeyPartition column is part of multi-column index
#51315
Conversation
Hi @jiyfhust. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51315 +/- ##
================================================
+ Coverage 70.6856% 72.7951% +2.1094%
================================================
Files 1462 1462
Lines 435275 435290 +15
================================================
+ Hits 307677 316870 +9193
+ Misses 108256 98457 -9799
- Partials 19342 19963 +621
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/test build |
@jiyfhust: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @Defined2014 @mjonss |
ref link #50210 |
/cc @tiancaiamao |
[LGTM Timeline notifier]Timeline:
|
/hold
|
/test check-dev |
@jiyfhust: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test check-dev2 |
@jiyfhust: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1d1beb9
to
944118c
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, mjonss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please sync with the master branch. |
Synced already. |
@tiancaiamao Can you remove the "/hod" lable after you appove this pr? |
/unhold |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #51313
Problem Summary:
Fix it reference point_get.
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.