Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix BatchPoint leads to tidb panic when KeyPartition column is part of multi-column index #51315

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

jiyfhust
Copy link
Contributor

@jiyfhust jiyfhust commented Feb 26, 2024

What problem does this PR solve?

Issue Number: close #51313

Problem Summary:

Fix it reference point_get.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Feb 26, 2024
Copy link

tiprow bot commented Feb 26, 2024

Hi @jiyfhust. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jiyfhust
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Merging #51315 (82719a1) into master (b01942d) will increase coverage by 2.1094%.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51315        +/-   ##
================================================
+ Coverage   70.6856%   72.7951%   +2.1094%     
================================================
  Files          1462       1462                
  Lines        435275     435290        +15     
================================================
+ Hits         307677     316870      +9193     
+ Misses       108256      98457      -9799     
- Partials      19342      19963       +621     
Flag Coverage Δ
integration 48.6545% <100.0000%> (?)
unit 70.4750% <60.0000%> (+0.0024%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.3912% <ø> (+5.5478%) ⬆️

@jiyfhust
Copy link
Contributor Author

/test build

Copy link

tiprow bot commented Feb 26, 2024

@jiyfhust: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tidb_parser_test
  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 26, 2024
@jiyfhust
Copy link
Contributor Author

/cc @Defined2014 @mjonss

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 1, 2024
@Defined2014
Copy link
Contributor

ref link #50210

@jiyfhust
Copy link
Contributor Author

jiyfhust commented Mar 4, 2024

/cc @tiancaiamao

@ti-chi-bot ti-chi-bot bot requested a review from tiancaiamao March 4, 2024 04:27
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 4, 2024
Copy link

ti-chi-bot bot commented Mar 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-01 08:53:00.245376555 +0000 UTC m=+1211268.992999661: ☑️ agreed by Defined2014.
  • 2024-03-04 09:00:54.743889136 +0000 UTC m=+71281.766135522: ☑️ agreed by mjonss.

@jiyfhust
Copy link
Contributor Author

jiyfhust commented Mar 4, 2024

/hold

time="2024-03-04T17:18:40+08:00" level=error msg="1 tests failed\n"

time="2024-03-04T17:18:40+08:00" level=error msg="run test [executor/batch_point_get] err: sql:explain format='brief' select col1, col2, col3 from tkey where col1 = 1 and col2 = 'a' or col1 = 3 and col2 = 'c';: run \"explain format='brief' select col1, col2, col3 from tkey where col1 = 1 and col2 = 'a' or col1 = 3 and col2 = 'c';\" at line 114 err, we got \nexplain format='brief' select col1, col2, col3 from tkey where col1 = 1 and col2 = 'a' or col1 = 3 and col2 = 'c';\nid\testRows\ttask\taccess object\toperator info\nIndexLookUp\t2.00\troot\tpartition:p3\t\n├─IndexRangeScan(Build)\t2.00\tcop[tikv]\ttable:tkey, index:col1(col1, col2)\trange:[1 \"a\",1 \"a\"], [3 \"c\",3 \"c\"], keep order:false, stats:pseudo\n└─TableRowIDScan(Probe)\t2.00\tcop[tikv]\ttable:tkey\tkeep order:false, stats:pseudo\n\nbut read result err EOF"

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2024
@jiyfhust
Copy link
Contributor Author

jiyfhust commented Mar 4, 2024

/test check-dev

Copy link

tiprow bot commented Mar 4, 2024

@jiyfhust: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jiyfhust
Copy link
Contributor Author

jiyfhust commented Mar 4, 2024

/test check-dev2

Copy link

tiprow bot commented Mar 4, 2024

@jiyfhust: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved labels Mar 4, 2024
@jiyfhust jiyfhust force-pushed the fix_batch_panic_key_parition branch from 1d1beb9 to 944118c Compare March 4, 2024 12:03
Copy link

ti-chi-bot bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, mjonss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 4, 2024
@hawkingrei
Copy link
Member

Please sync with the master branch.

@jiyfhust
Copy link
Contributor Author

jiyfhust commented Mar 4, 2024

Please sync with the master branch.

Synced already.

@jiyfhust
Copy link
Contributor Author

jiyfhust commented Mar 4, 2024

@tiancaiamao Can you remove the "/hod" lable after you appove this pr?

@jiyfhust
Copy link
Contributor Author

jiyfhust commented Mar 4, 2024

@tiancaiamao Can you remove the "/hod" lable after you appove this pr?

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2024
@ti-chi-bot ti-chi-bot bot merged commit c1befbb into pingcap:master Mar 4, 2024
23 checks passed
@jiyfhust jiyfhust deleted the fix_batch_panic_key_parition branch March 4, 2024 12:54
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label May 22, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #53486.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 22, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

batchPoint leads to tidb panic when KeyPartition column is part of multi-column index
5 participants