Skip to content

planner: add more test cases for plan cache with generated columns#51314

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
qw4990:plan-cache-gencol-test
Feb 26, 2024
Merged

planner: add more test cases for plan cache with generated columns#51314
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
qw4990:plan-cache-gencol-test

Conversation

@qw4990

@qw4990 qw4990 commented Feb 26, 2024

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: ref #45798

Problem Summary: planner: add more test cases for plan cache with generated columns

What changed and how does it work?

planner: add more test cases for plan cache with generated columns

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 26, 2024
@tiprow

tiprow Bot commented Feb 26, 2024

Copy link
Copy Markdown

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 26, 2024
@ti-chi-bot

ti-chi-bot Bot commented Feb 26, 2024

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [AilinKid,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 26, 2024
@ti-chi-bot

ti-chi-bot Bot commented Feb 26, 2024

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2024-02-26 07:10:48.952280755 +0000 UTC m=+859537.699903864: ☑️ agreed by hawkingrei.
  • 2024-02-26 07:12:25.406539079 +0000 UTC m=+859634.154162190: ☑️ agreed by AilinKid.

@codecov

codecov Bot commented Feb 26, 2024

Copy link
Copy Markdown

Codecov Report

Merging #51314 (3088efe) into master (15a8459) will decrease coverage by 17.2438%.
The diff coverage is n/a.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #51314         +/-   ##
=================================================
- Coverage   70.6398%   53.3960%   -17.2438%     
=================================================
  Files          1459       1568        +109     
  Lines        434200     602985     +168785     
=================================================
+ Hits         306718     321970      +15252     
- Misses       108254     259102     +150848     
- Partials      19228      21913       +2685     
Flag Coverage Δ
integration 18.8700% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 47.7561% <ø> (+1.8816%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants