table: fix issue of get default value from column when column doesn't have default value | tidb-test=pr/2305

[crazycs520]

What problem does this PR solve?

Issue Number: close #50043, close #51324

Problem Summary:

• fix issue assertion failed when inserting some rows #50043 that get wrong default value when column doesn't have default value.
• fix issue of default value of column with no default value behavior is not compatible with mysql 8.0.29 #51324 that default value of column with no default value behavior is not compatible with mysql 8.0.29

What changed and how does it work?

This PR reverts some changes introduced by #35072 and use another way to check ErrNoDefaultValue before insert.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @crazycs520. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[crazycs520]

@wjhuang2016 @lcwangchao @Defined2014 @bb7133 PTAL

[codecov]

Codecov Report

Merging #51309 (cd81625) into master (332086e) will increase coverage by 2.0880%.
Report is 11 commits behind head on master.
The diff coverage is 93.9393%.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #51309        +/-   ##
================================================
+ Coverage   70.6521%   72.7401%   +2.0880%     
================================================
  Files          1461       1462         +1     
  Lines        434859     435586       +727     
================================================
+ Hits         307237     316846      +9609     
+ Misses       108346      98794      -9552     
- Partials      19276      19946       +670     

Flag	Coverage Δ
integration	48.9146% <66.6666%> (?)
unit	70.4137% <93.9393%> (-0.0305%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <ø> (ø)
parser	∅ <ø> (∅)
br	51.2473% <ø> (+5.4221%)	⬆️

[crazycs520]

@tangenta @zimulala @tiancaiamao PTAL

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-02-26 07:33:33.281527318 +0000 UTC m=+860902.029150422: ☑️ agreed by zimulala.
• 2024-02-26 08:07:14.455861833 +0000 UTC m=+862923.203484943: ☑️ agreed by Defined2014.

[crazycs520]

/hold , Since I may found other bug.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, lcwangchao, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Defined2014,lcwangchao,zimulala]
• pkg/ddl/OWNERS [zimulala]
• pkg/table/OWNERS [zimulala]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.1: #51386.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #51390.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.5: #51391.