Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: stop pushing Agg down through Projection if substitution fail #50932

Merged
merged 4 commits into from
Feb 4, 2024

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Feb 2, 2024

What problem does this PR solve?

Issue Number: close #50926

Problem Summary: planner: stop pushing Agg down through Projection if substitution fail

What changed and how does it work?

planner: stop pushing Agg down through Projection if substitution fail

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 2, 2024
Copy link

tiprow bot commented Feb 2, 2024

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 2, 2024
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Merging #50932 (c9bc4e9) into master (ff8b3d3) will increase coverage by 2.1061%.
Report is 10 commits behind head on master.
The diff coverage is 47.0588%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #50932        +/-   ##
================================================
+ Coverage   70.5083%   72.6144%   +2.1061%     
================================================
  Files          1466       1466                
  Lines        434007     434554       +547     
================================================
+ Hits         306011     315549      +9538     
+ Misses       108730      99099      -9631     
- Partials      19266      19906       +640     
Flag Coverage Δ
integration 48.9515% <47.0588%> (?)
unit 70.2710% <23.5294%> (-0.0472%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.1120% <ø> (ø)
parser ∅ <ø> (∅)
br 51.0664% <ø> (+5.3226%) ⬆️

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 4, 2024
Copy link

ti-chi-bot bot commented Feb 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-02 08:34:41.235271162 +0000 UTC m=+1727322.799568852: ☑️ agreed by AilinKid.
  • 2024-02-04 05:46:16.368897382 +0000 UTC m=+76501.935667269: ☑️ agreed by hawkingrei.

Copy link

ti-chi-bot bot commented Feb 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, guo-shaoge, hawkingrei, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 4, 2024
@ti-chi-bot ti-chi-bot bot merged commit a0296be into pingcap:master Feb 4, 2024
23 checks passed
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Feb 5, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #50991.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 5, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@qw4990
Copy link
Contributor Author

qw4990 commented Feb 19, 2024

/cherry-pick release-6.5

@qw4990
Copy link
Contributor Author

qw4990 commented Feb 19, 2024

/cherry-pick release-7.1

@ti-chi-bot
Copy link
Member

@qw4990: new pull request created to branch release-6.5: #51134.

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 19, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

@qw4990: new pull request created to branch release-7.1: #51135.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 19, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@qw4990 qw4990 added the type/bugfix This PR fixes a bug. label Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

planner: the optimizer returns 'cannot find column' error when aggregating view with json columns
6 participants