Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema: remove some redundant methods from InfoSchema #50916

Merged
merged 4 commits into from
Feb 4, 2024

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Feb 1, 2024

What problem does this PR solve?

Issue Number: ref #50959

Problem Summary:

What changed and how does it work?

We're going to implement the InfoSchemaV2, the new implementation need to keep almost the same interface.
So, remove the redundant methods can make the refactor easier.

AllSchemaNames() []string
TableIsView(schema, table model.CIStr) bool
TableIsSequence(schema, table model.CIStr) bool

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Just tiny refactor, no functional changes.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 1, 2024
Copy link

tiprow bot commented Feb 1, 2024

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiancaiamao tiancaiamao changed the title infoschema: remove some duplicated methods from InfoSchema interface infoschema: remove some redundant methods from InfoSchema Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Merging #50916 (3c452f8) into master (c76fe3f) will increase coverage by 2.1981%.
Report is 23 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #50916        +/-   ##
================================================
+ Coverage   70.5619%   72.7600%   +2.1980%     
================================================
  Files          1466       1467         +1     
  Lines        433823     437255      +3432     
================================================
+ Hits         306114     318147     +12033     
+ Misses       108537      99041      -9496     
- Partials      19172      20067       +895     
Flag Coverage Δ
integration 48.9676% <68.7500%> (?)
unit 70.2579% <93.7500%> (-0.1256%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.2940% <ø> (ø)
parser ∅ <ø> (∅)
br 51.2032% <ø> (+5.4283%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 2, 2024
@tiancaiamao
Copy link
Contributor Author

/test pull-integration-ddl-test

Copy link

tiprow bot commented Feb 2, 2024

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-integration-ddl-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiancaiamao
Copy link
Contributor Author

PTAL @GMHDBJD

@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 3, 2024
Copy link

ti-chi-bot bot commented Feb 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 3, 2024
Copy link

ti-chi-bot bot commented Feb 3, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-02 07:20:53.098308921 +0000 UTC m=+1722894.662606611: ☑️ agreed by zimulala.
  • 2024-02-03 14:37:13.03621394 +0000 UTC m=+21958.602983833: ☑️ agreed by AilinKid.

@ti-chi-bot ti-chi-bot bot merged commit c6d7270 into pingcap:master Feb 4, 2024
22 of 23 checks passed
@tiancaiamao tiancaiamao deleted the infoschema-api branch February 4, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants