Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hint: refactor PlanHints #50768

Merged
merged 5 commits into from
Jan 29, 2024
Merged

hint: refactor PlanHints #50768

merged 5 commits into from
Jan 29, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jan 29, 2024

What problem does this PR solve?

Issue Number: ref #48875

Problem Summary:

What changed and how does it work?

remove Agghint in the PlanHints. we need to remove AggHint in the other LogicalPlan.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 29, 2024
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 29, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 29, 2024
Copy link
Contributor

@elsa0520 elsa0520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elsa0520, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 29, 2024
Copy link

ti-chi-bot bot commented Jan 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-29 03:18:06.958900523 +0000 UTC m=+1362728.523198228: ☑️ agreed by qw4990.
  • 2024-01-29 03:19:29.988422885 +0000 UTC m=+1362811.552720590: ☑️ agreed by elsa0520.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Merging #50768 (135a916) into master (6a87b80) will increase coverage by 2.0567%.
Report is 2 commits behind head on master.
The diff coverage is 95.3846%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #50768        +/-   ##
================================================
+ Coverage   70.5970%   72.6538%   +2.0567%     
================================================
  Files          1463       1463                
  Lines        433201     433629       +428     
================================================
+ Hits         305827     315048      +9221     
+ Misses       108260      98700      -9560     
- Partials      19114      19881       +767     
Flag Coverage Δ
integration 49.2212% <87.6923%> (?)
unit 70.2795% <100.0000%> (-0.1395%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.2940% <ø> (ø)
parser ∅ <ø> (∅)
br 51.2776% <ø> (+5.4745%) ⬆️

@ti-chi-bot ti-chi-bot bot merged commit 1760a26 into pingcap:master Jan 29, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants