-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hint: refactor PlanHints #50768
hint: refactor PlanHints #50768
Conversation
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elsa0520, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #50768 +/- ##
================================================
+ Coverage 70.5970% 72.6538% +2.0567%
================================================
Files 1463 1463
Lines 433201 433629 +428
================================================
+ Hits 305827 315048 +9221
+ Misses 108260 98700 -9560
- Partials 19114 19881 +767
Flags with carried forward coverage won't be shown. Click here to find out more.
|
What problem does this PR solve?
Issue Number: ref #48875
Problem Summary:
What changed and how does it work?
remove Agghint in the PlanHints. we need to remove AggHint in the other LogicalPlan.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.