Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta/autoid: make autoid client ResetConn operation concurrency-safe (#50522) #50594

Merged
merged 3 commits into from
Jan 20, 2024

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #50519

Problem Summary:

What changed and how does it work?

Cherry-pick #50522 for a hotfix

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 19, 2024
Copy link

tiprow bot commented Jan 19, 2024

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

zimulala
zimulala previously approved these changes Jan 19, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5-20231214-v7.5.0@ed04098). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             release-7.5-20231214-v7.5.0     #50594   +/-   ##
================================================================
  Coverage                               ?   71.9356%           
================================================================
  Files                                  ?       1398           
  Lines                                  ?     406337           
  Branches                               ?          0           
================================================================
  Hits                                   ?     292301           
  Misses                                 ?      94366           
  Partials                               ?      19670           
Flag Coverage Δ
unit 71.9356% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.2559% <0.0000%> (?)

@tiancaiamao
Copy link
Contributor Author

/test build

Copy link

tiprow bot commented Jan 19, 2024

@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

xhebox
xhebox previously approved these changes Jan 19, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 19, 2024
Copy link

ti-chi-bot bot commented Jan 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-19 09:35:08.303861676 +0000 UTC m=+521349.868159378: ☑️ agreed by zimulala.
  • 2024-01-19 14:46:34.67289836 +0000 UTC m=+540036.237196065: ☑️ agreed by xhebox.

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jan 19, 2024
@hawkingrei
Copy link
Member

/test all

Copy link

tiprow bot commented Jan 19, 2024

@hawkingrei: No presubmit jobs available for pingcap/tidb@release-7.5-20231214-v7.5.0

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiancaiamao
Copy link
Contributor Author

/test build

Copy link

tiprow bot commented Jan 20, 2024

@tiancaiamao: No presubmit jobs available for pingcap/tidb@release-7.5-20231214-v7.5.0

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiancaiamao tiancaiamao dismissed stale reviews from xhebox and zimulala via 48fa366 January 20, 2024 01:57
@ti-chi-bot ti-chi-bot bot removed the approved label Jan 20, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 20, 2024
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Jan 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bb7133
Once this PR has been reviewed and has the lgtm label, please assign zimulala for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit b856499 into pingcap:release-7.5-20231214-v7.5.0 Jan 20, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants