Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindinfo: SetSkipPlanCache use nostack errors #50585

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jan 19, 2024

What problem does this PR solve?

Issue Number: close #49291

Problem Summary:

What changed and how does it work?

ZGW8p7ISIB

it is found in the v7.5.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Jan 19, 2024
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Merging #50585 (cfa3750) into master (1442f07) will decrease coverage by 14.6932%.
Report is 1 commits behind head on master.
The diff coverage is 93.7500%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50585         +/-   ##
=================================================
- Coverage   70.1822%   55.4890%   -14.6932%     
=================================================
  Files          1452       1563        +111     
  Lines        420457     587831     +167374     
=================================================
+ Hits         295086     326182      +31096     
- Misses       104993     238909     +133916     
- Partials      20378      22740       +2362     
Flag Coverage Δ
integration 36.5876% <87.5000%> (?)
unit 70.1781% <81.2500%> (-0.0041%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 56.4409% <ø> (+6.0043%) ⬆️

@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 19, 2024
Copy link

ti-chi-bot bot commented Jan 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-19 04:50:17.358989838 +0000 UTC m=+504258.923287536: ☑️ agreed by AilinKid.
  • 2024-01-19 05:29:41.099588829 +0000 UTC m=+506622.663886534: ☑️ agreed by qw4990.

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Jan 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, qw4990, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 19, 2024
@ti-chi-bot ti-chi-bot bot merged commit bfa10bd into pingcap:master Jan 19, 2024
20 checks passed
@hawkingrei hawkingrei deleted the 49291 branch January 19, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

planner: care to use errors.new and errors.errorf as your warnings and notes
4 participants