Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exectuor: add stack trace for runtime panic #50449

Merged
merged 3 commits into from
Jan 16, 2024
Merged

exectuor: add stack trace for runtime panic #50449

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c0ec88
fix: add logs for recover
Rustin170506 Jan 16, 2024
1efcc1e
fix: add more logs
Rustin170506 Jan 16, 2024
8cd8615
fix: add stack for runtime error
Rustin170506 Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/util/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,9 @@ func IsInCorrectIdentifierName(name string) bool {
// GetRecoverError gets the error from recover.
func GetRecoverError(r interface{}) error {
if err, ok := r.(error); ok {
return err
// Runtime panic also implements error interface.
// So do not forget to add stack info for it.
return errors.Trace(err)
}
return errors.Errorf("%v", r)
}