Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema: set the correct type for REMAINING_SECONDS #50421

Merged

Conversation

Rustin170506
Copy link
Member

What problem does this PR solve?

Issue Number: close #48835

Problem Summary:

What changed and how does it work?

It should be varchar instead of int64.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that users can not select data from the `information_schema.analyze_status` table

Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed do-not-merge/needs-triage-completed labels Jan 15, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 15, 2024
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Merging #50421 (5bd9895) into master (2ca9f98) will decrease coverage by 15.5275%.
The diff coverage is n/a.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #50421         +/-   ##
=================================================
- Coverage   70.0824%   54.5550%   -15.5275%     
=================================================
  Files          1445       1556        +111     
  Lines        420028     586952     +166924     
=================================================
+ Hits         294366     320212      +25846     
- Misses       105370     244913     +139543     
- Partials      20292      21827       +1535     
Flag Coverage Δ
integration 34.7789% <ø> (?)
unit 70.0324% <ø> (-0.0500%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (ø)
parser ∅ <ø> (∅)
br 51.5400% <ø> (+1.8435%) ⬆️

@Rustin170506 Rustin170506 changed the title fix: set correct type for REMAINING_SECONDS infoschema: set correct type for REMAINING_SECONDS Jan 15, 2024
@Rustin170506 Rustin170506 changed the title infoschema: set correct type for REMAINING_SECONDS infoschema: set the correct type for REMAINING_SECONDS Jan 15, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 15, 2024
Copy link

ti-chi-bot bot commented Jan 15, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-15 07:51:20.39512707 +0000 UTC m=+169521.959424763: ☑️ agreed by hawkingrei.
  • 2024-01-15 08:06:04.929290309 +0000 UTC m=+170406.493588014: ☑️ agreed by qw4990.

@ywqzzy
Copy link
Contributor

ywqzzy commented Jan 15, 2024

/lgtm

Copy link

ti-chi-bot bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, qw4990, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 15, 2024
@Rustin170506
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 357be8b into pingcap:master Jan 15, 2024
22 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #50431.

@Rustin170506
Copy link
Member Author

cc: #50449

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #50596.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.6 release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

query analyze_status table got panic
5 participants