Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brie: support batch ddl for sql restore (#49089) #49851

Merged
merged 6 commits into from
Dec 28, 2023
Merged

brie: support batch ddl for sql restore (#49089) #49851

merged 6 commits into from
Dec 28, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #49089

What problem does this PR solve?

Issue Number: close #48301

Problem Summary:
brie restore need batch ddl to accelerate the table creation。

What changed and how does it work?

implement CreateTables function for brieGlue

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Leavrth @ti-chi-bot
This is an automated cherry-pick of pingcap#49089
aec33e8 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Dec 27, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 27, 2023
Merged
13 tasks
@Leavrth
resolve conflicts
6be7646 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 27, 2023
Leavrth
Leavrth reviewed Dec 27, 2023
View reviewed changes
executor/brie.go
return fn(gs)
// GetSessionCtx implements glue.Glue
func (gs *tidbGlueSession) GetSessionCtx() sessionctx.Context {
return gs.se
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice: need to create a new sessionctx if implement stream

@Leavrth
remove some conflicts
d2ae7a0 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
fix unit test
0beb2e0 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
Copy link
Contributor

Leavrth commented Dec 27, 2023

/test pull-br-integration-test

@tiprow tiprow
Copy link

tiprow bot commented Dec 27, 2023

@Leavrth: No presubmit jobs available for pingcap/tidb@release-6.5

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 27, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 27, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 27, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-27 11:26:39.848969547 +0000 UTC m=+1651490.886196474: ☑️ agreed by Leavrth.
  • 2023-12-27 12:07:36.637287732 +0000 UTC m=+1653947.674514660: ☑️ agreed by BornChanger.

@hawkingrei
Copy link
Member

/retest

2 similar comments
@Leavrth
Copy link
Contributor

Leavrth commented Dec 27, 2023

/retest

@Leavrth
Copy link
Contributor

Leavrth commented Dec 27, 2023

/retest

@Leavrth
fix data race
723e129 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
fix integration test
965206f 
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
Copy link
Contributor

Leavrth commented Dec 28, 2023

/test pull-br-integration-test

@tiprow tiprow
Copy link

tiprow bot commented Dec 28, 2023

@Leavrth: No presubmit jobs available for pingcap/tidb@release-6.5

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Leavrth
Copy link
Contributor

Leavrth commented Dec 28, 2023

/retest

1 similar comment
@Leavrth
Copy link
Contributor

Leavrth commented Dec 28, 2023

/retest

@codecov Codecov
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@1dcf7b8). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-6.5     #49851   +/-   ##
================================================
  Coverage               ?   73.6640%           
================================================
  Files                  ?       1090           
  Lines                  ?     349928           
  Branches               ?          0           
================================================
  Hits                   ?     257771           
  Misses                 ?      75611           
  Partials               ?      16546

@ti-chi-bot ti-chi-bot bot merged commit 767ec62 into pingcap:release-6.5 Dec 28, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leavrth Leavrth Leavrth approved these changes

@BornChanger BornChanger BornChanger approved these changes

Assignees

@Leavrth Leavrth

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @Leavrth @hawkingrei @BornChanger