Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brie: support batch ddl for sql restore (#49089) #49849

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #49089

What problem does this PR solve?

Issue Number: close #48301

Problem Summary:
brie restore need batch ddl to accelerate the table creation。

What changed and how does it work?

implement CreateTables function for brieGlue

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Dec 27, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 1, 2024
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
Copy link
Contributor

Leavrth commented Feb 27, 2024

/test pull-br-integration-test

Copy link

tiprow bot commented Feb 27, 2024

@Leavrth: No presubmit jobs available for pingcap/tidb@release-7.1

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@Leavrth
Copy link
Contributor

Leavrth commented Feb 27, 2024

/retest

1 similar comment
@Leavrth
Copy link
Contributor

Leavrth commented Feb 27, 2024

/retest

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 27, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 27, 2024
Copy link

ti-chi-bot bot commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 27, 2024
Copy link

ti-chi-bot bot commented Feb 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-27 08:48:17.061948848 +0000 UTC m=+951785.809571959: ☑️ agreed by BornChanger.
  • 2024-02-27 09:11:28.067299687 +0000 UTC m=+953176.814922795: ☑️ agreed by YuJuncen.

@BornChanger
Copy link
Contributor

/retest

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1@4d53073). Click here to learn what that means.
The diff coverage is 50.5494%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #49849   +/-   ##
================================================
  Coverage               ?   73.4286%           
================================================
  Files                  ?       1211           
  Lines                  ?     379349           
  Branches               ?          0           
================================================
  Hits                   ?     278551           
  Misses                 ?      83017           
  Partials               ?      17781           

@BornChanger
Copy link
Contributor

/retest

1 similar comment
@BornChanger
Copy link
Contributor

/retest

@BornChanger
Copy link
Contributor

/retest

@BornChanger
Copy link
Contributor

/rerun

@BornChanger
Copy link
Contributor

/retest

1 similar comment
@Leavrth
Copy link
Contributor

Leavrth commented Feb 28, 2024

/retest

Copy link

ti-chi-bot bot commented Feb 28, 2024

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-br-integration-test 65c8f75 link false /test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot merged commit 8aa07d2 into pingcap:release-7.1 Feb 28, 2024
9 checks passed
@wuhuizuo wuhuizuo deleted the cherry-pick-49089-to-release-7.1 branch February 28, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants