Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix the optimization for the empty table(speed up) (#49629) #49815

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #49629

What problem does this PR solve?

Issue Number: close #49679, close #49682

Problem Summary:
The optimization for the empty table(startKey == nil && endKey == nil) doesn't work.
The following case is obvious (because split regions take so long).
#49679

[2023/12/20 11:23:10.873 +08:00] [INFO] [backfilling.go:712] ["start backfill workers to reorg record"] [category=ddl] [type="add index"] [workerCnt=4] [regionCnt=1] [startKey=] [endKey=]
...
[2023/12/20 11:25:14.752 +08:00] [INFO] [backfilling.go:559] ["get backfill range task, get reverse key failed"] [category=ddl] [error="[tikv:9005]Region is unavailable"]
...
...

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
    Before this PR, took time: 2min+
    image

After this PR, took time: 40s+
img_v3_026b_4698de00-e023-4c0a-990d-8cdb530e67bg

  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Dec 26, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 21, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 22, 2024
Copy link

ti-chi-bot bot commented Feb 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 22, 2024
Copy link

ti-chi-bot bot commented Feb 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-22 08:03:58.32123477 +0000 UTC m=+517127.068857881: ☑️ agreed by Defined2014.
  • 2024-02-22 08:04:15.926657795 +0000 UTC m=+517144.674281223: ☑️ agreed by tangenta.

@Defined2014
Copy link
Contributor

/retest

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1@4d53073). Click here to learn what that means.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #49815   +/-   ##
================================================
  Coverage               ?   73.4193%           
================================================
  Files                  ?       1209           
  Lines                  ?     378809           
  Branches               ?          0           
================================================
  Hits                   ?     278119           
  Misses                 ?      82927           
  Partials               ?      17763           

@ti-chi-bot ti-chi-bot bot merged commit 99e2a21 into pingcap:release-7.1 Feb 22, 2024
9 checks passed
@Defined2014 Defined2014 deleted the cherry-pick-49629-to-release-7.1 branch February 22, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants