*: remove localstore dependency. #4965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanfei1991
changed the title
|
/run-all-test |
|
/run-all-tests |
|
leveldb is used in tidb-test |
coocood
reviewed
Nov 1, 2017
| } | ||
|
|
||
| // End implements autoid.Allocator End interface. | ||
| func (alloc *allocator) End() int64 { |
There was a problem hiding this comment.
Why do we need End if it the same as Base?
There was a problem hiding this comment.
My fault, it should return end
|
/run-all-tests |
|
/run-all-test tidb-test=pr/388 |
|
/run-all-test tidb-test=pr/388 |
|
@coocood PTAL |
zz-jason
reviewed
Nov 1, 2017
| @@ -44,7 +44,6 @@ func (s *testBootstrapSuite) TestBootstrap(c *C) { | |||
| defer testleak.AfterTest(c)() | |||
| store, dom := newStoreWithBootstrap(c, s.dbName) | |||
| defer dom.Close() | |||
| defer store.Close() | |||
There was a problem hiding this comment.
because store has been closed in line 97
zimulala
reviewed
Nov 1, 2017
perfschema/init.go
Outdated
| @@ -349,11 +349,19 @@ func (ps *perfSchema) initialize() { | |||
| ps.buildTables() | |||
| } | |||
|
|
|||
| func (ps *perfSchema) GetDBMeta() *model.DBInfo { | |||
| // GetDBMeta returns the db info. | |||
server/tidb_test.go
Outdated
| store, err := tidb.NewStore("memory:///tmp/tidb") | ||
| store, err := tikv.NewMockTikvStore() | ||
| tidb.SetStatsLease(0) | ||
| tidb.SetSchemaLease(0) |
There was a problem hiding this comment.
I think this code can be removed. Because we use mock syncer.
|
LGTM |
zz-jason
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.