parser: fix invalid hint addition disable other valid hints (#49441) #49607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added
release-note-none
13 tasks
ti-chi-bot
bot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ti-chi-bot
added
the
cherry-pick-approved
hawkingrei
approved these changes
Feb 26, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
fixdb
approved these changes
Feb 26, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fixdb, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
hawkingrei
removed
the
needs-rebase
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #49607 +/- ##
================================================
Coverage ? 73.5966%
================================================
Files ? 1210
Lines ? 380171
Branches ? 0
================================================
Hits ? 279793
Misses ? 82678
Partials ? 17700 |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #49441
What problem does this PR solve?
Issue Number: close #49308
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.