Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl, statistics: resolve the package dependency. #4960

Merged
merged 2 commits into from
Oct 31, 2017
Merged

ddl, statistics: resolve the package dependency. #4960

merged 2 commits into from
Oct 31, 2017

Conversation

hanfei1991
Copy link
Member

change ddl_test's storage to mock-tikv

winoros
winoros reviewed Oct 31, 2017
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanfei1991
Copy link
Member Author

relate #4779

@hanfei1991 hanfei1991 added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 31, 2017
alivxxx
alivxxx approved these changes Oct 31, 2017
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanfei1991 hanfei1991 merged commit 35fe2ca into pingcap:master Oct 31, 2017
@hanfei1991 hanfei1991 deleted the ddl_test branch October 31, 2017 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@alivxxx alivxxx alivxxx approved these changes

Assignees
No one assigned
Labels
status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanfei1991 @winoros @alivxxx