Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: ignore schema name if WithoutSchemaNameFlag is set when restoring hints #49587

Merged
merged 5 commits into from
Dec 19, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Dec 19, 2023

What problem does this PR solve?

Issue Number: ref #48875

Problem Summary: parser: ignore schema name if WithoutSchemaNameFlag is set when restoring hints

What changed and how does it work?

parser: ignore schema name if WithoutSchemaNameFlag is set when restoring hints

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 19, 2023
Copy link

tiprow bot commented Dec 19, 2023

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Dec 19, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #49587 (4c05e26) into master (ad1efe4) will increase coverage by 0.4618%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49587        +/-   ##
================================================
+ Coverage   71.0028%   71.4646%   +0.4618%     
================================================
  Files          1368       1421        +53     
  Lines        399204     415943     +16739     
================================================
+ Hits         283446     297252     +13806     
- Misses        95973      99890      +3917     
+ Partials      19785      18801       -984     
Flag Coverage Δ
integration 43.8370% <ø> (?)
unit 71.0025% <ø> (-0.0003%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 47.3644% <ø> (-5.5178%) ⬇️

Copy link

ti-chi-bot bot commented Dec 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 19, 2023
Copy link

ti-chi-bot bot commented Dec 19, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-19 09:16:44.091770847 +0000 UTC m=+952495.128997774: ☑️ agreed by hawkingrei.
  • 2023-12-19 09:17:24.554615594 +0000 UTC m=+952535.591842521: ☑️ agreed by tangenta.

@qw4990
Copy link
Contributor Author

qw4990 commented Dec 19, 2023

/test check-dev2

Copy link

tiprow bot commented Dec 19, 2023

@qw4990: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 7d33d0d into pingcap:master Dec 19, 2023
17 checks passed
@qw4990
Copy link
Contributor Author

qw4990 commented May 21, 2024

/cherry-pick release-7.5

@ti-chi-bot
Copy link
Member

@qw4990: new pull request created to branch release-7.5: #53433.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 21, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants