Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: exit tidb-server directly when all connections not in txn (#44953) #49481

Merged

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Dec 14, 2023

This is a manual backport of #44953:


What problem does this PR solve?

Issue Number: close #44951

Problem Summary: After #32111, user need to wait for all connections to be disconnected, or execute a new sql before tidb-server exit. It's not an expected behaviour.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Exit tidb-server directly when all connections not in txn

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 14, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 15, 2023
@Defined2014
Copy link
Contributor

/retest

@purelind
Copy link
Contributor

The branch naming tidb-6.5-with-kv-timeout-feature is not in the correct format. I will handle the triggering of this branch separately.

@purelind
Copy link
Contributor

/test ?

Copy link

ti-chi-bot bot commented Dec 15, 2023

@purelind: The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

tiprow bot commented Dec 15, 2023

@purelind: No presubmit jobs available for pingcap/tidb@tidb-6.5-with-kv-timeout-feature

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bb7133
Copy link
Member Author

bb7133 commented Dec 18, 2023

/retest

Copy link

ti-chi-bot bot commented Dec 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazycs520, Defined2014

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,crazycs520]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 19, 2023
Copy link

ti-chi-bot bot commented Dec 19, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-15 01:50:34.256287029 +0000 UTC m=+580125.293513956: ☑️ agreed by Defined2014.
  • 2023-12-19 09:02:47.017420924 +0000 UTC m=+951658.054647851: ☑️ agreed by crazycs520.

@hawkingrei
Copy link
Member

/retest

Copy link

ti-chi-bot bot commented Dec 19, 2023

@bb7133: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test 743a51e link true /test unit-test
idc-jenkins-ci-tidb/mysql-test 743a51e link true /test mysql-test
idc-jenkins-ci-tidb/check_dev_2 743a51e link true /test check-dev2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bb7133 bb7133 merged commit d76eb25 into pingcap:tidb-6.5-with-kv-timeout-feature Dec 20, 2023
3 of 7 checks passed
@bb7133 bb7133 deleted the bb7133/kv-branch-44953 branch December 21, 2023 06:19
guoshouyan pushed a commit to guoshouyan/tidb that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants