-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: support creating universal bindings #49426
Conversation
Hi @qw4990. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49426 +/- ##
================================================
+ Coverage 71.0560% 71.7134% +0.6573%
================================================
Files 1368 1417 +49
Lines 401362 421603 +20241
================================================
+ Hits 285192 302346 +17154
- Misses 96344 100291 +3947
+ Partials 19826 18966 -860
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, easonn7, elsa0520, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #48875
Problem Summary: planner: support creating universal bindings
What changed and how does it work?
Implement the syntax in TiDB:
type
to indicate whether this binding is a universal binding, '' for normal and 'u' for universal bindings;Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.