Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: encapsulate binding operations behind 2 interfaces #49261

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Dec 7, 2023

What problem does this PR solve?

Issue Number: ref #48875

Problem Summary: planner: encapsulate binding operations behind 2 interfaces

What changed and how does it work?

planner: encapsulate binding operations behind 2 interfaces

NO LOGICAL CHANGE, JUST REFACTOR

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 7, 2023
Copy link

tiprow bot commented Dec 7, 2023

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #49261 (a3c6141) into master (5db7c6a) will increase coverage by 0.9980%.
Report is 4 commits behind head on master.
The diff coverage is 67.5675%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #49261        +/-   ##
================================================
+ Coverage   71.0505%   72.0485%   +0.9980%     
================================================
  Files          1368       1407        +39     
  Lines        402170     413929     +11759     
================================================
+ Hits         285744     298230     +12486     
- Misses        96553      96882       +329     
+ Partials      19873      18817      -1056     
Flag Coverage Δ
integration 43.7823% <67.5675%> (?)
unit 71.0491% <ø> (-0.0014%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 48.2512% <ø> (-4.6804%) ⬇️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 7, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 7, 2023
Copy link

ti-chi-bot bot commented Dec 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-07 12:04:41.384897828 +0000 UTC m=+1701910.050124022: ☑️ agreed by tangenta.
  • 2023-12-07 12:12:23.796924409 +0000 UTC m=+1702372.462150605: ☑️ agreed by hawkingrei.

@easonn7
Copy link

easonn7 commented Dec 7, 2023

/approve

Copy link

ti-chi-bot bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, hawkingrei, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 7, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Dec 7, 2023

/test mysql-test

Copy link

tiprow bot commented Dec 7, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor Author

qw4990 commented Dec 7, 2023

/test mysql-test

Copy link

tiprow bot commented Dec 7, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor Author

qw4990 commented Dec 7, 2023

/test mysql-test

Copy link

tiprow bot commented Dec 7, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990
Copy link
Contributor Author

qw4990 commented Dec 8, 2023

/test mysql-test

Copy link

tiprow bot commented Dec 8, 2023

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 90e272a into pingcap:master Dec 8, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants