vars: add `pd_enable_follower_handle_region` to support get region from pd follower #49231

CabinfeverB · 2023-12-06T13:31:05Z

What problem does this PR solve?

Issue Number: close #49747

Problem Summary:

What changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

ti-chi-bot · 2023-12-06T13:31:09Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

tiprow · 2023-12-06T13:31:24Z

Hi @CabinfeverB. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

CabinfeverB · 2023-12-06T13:47:52Z

/ok-to-test

CabinfeverB · 2023-12-06T13:53:09Z

/retest-required

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

CabinfeverB · 2023-12-25T05:26:36Z

/ok-to-test

CabinfeverB · 2023-12-25T05:57:45Z

/test build

tiprow · 2023-12-25T05:58:07Z

@CabinfeverB: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

CabinfeverB · 2023-12-25T06:40:45Z

/retest-required

codecov · 2023-12-25T06:59:47Z

Codecov Report

Merging #49231 (65d2b14) into master (6f32664) will increase coverage by 10.0645%.
Report is 4 commits behind head on master.
The diff coverage is 90.0000%.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #49231         +/-   ##
=================================================
+ Coverage   71.8820%   81.9466%   +10.0645%     
=================================================
  Files          1439       2442       +1003     
  Lines        346160     673187     +327027     
=================================================
+ Hits         248827     551654     +302827     
- Misses        77058     100848      +23790     
- Partials      20275      20685        +410

Flag	Coverage Δ
integration	`48.8642% <85.7142%> (?)`
unit	`79.2930% <90.0000%> (+7.4109%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`73.6130% <ø> (+17.3001%)`	⬆️
parser	`∅ <ø> (∅)`
br	`71.8804% <ø> (+20.4214%)`	⬆️

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com> rename Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

CabinfeverB · 2023-12-27T06:45:18Z

/test tiprow_fast_test

ti-chi-bot · 2023-12-27T06:45:21Z

@CabinfeverB: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-integration-ddl-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test unit-test

The following commands are available to trigger optional jobs:

/test canary-notify-when-compatibility-sections-changed
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-br-integration-test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-sqllogic-test
/test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_mysql_client_test

In response to this:

/test tiprow_fast_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

CabinfeverB · 2023-12-28T03:36:24Z

/retest-required

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

CabinfeverB · 2024-01-02T03:16:05Z

/retest-required

easonn7 · 2024-01-02T04:04:30Z

/approve

nolouch · 2024-01-02T04:10:45Z

pkg/sessionctx/variable/tidb_vars.go

@@ -722,6 +722,9 @@ const (
 	// TiDBEnableTSOFollowerProxy indicates whether to enable the TSO Follower Proxy feature of PD client.
 	TiDBEnableTSOFollowerProxy = "tidb_enable_tso_follower_proxy"

+	// PDEnableFollowerRegionAPI indicates whether to enable the PD Follower handle region API.
+	PDEnableFollowerRegionAPI = "pd_enable_follower_region_api"


How about pd_enable_follower_handle_region

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

rleungx · 2024-01-02T07:11:39Z

pkg/domain/domain_sysvars.go

@@ -69,6 +69,15 @@ func (do *Domain) setPDClientDynamicOption(name, sVal string) {
 			break
 		}
 		variable.EnableTSOFollowerProxy.Store(val)
+	case variable.PDEnableFollowerHandleRegion:
+		val := variable.TiDBOptOn(sVal)
+		// Note: EnableFollowerHandle is only used for region API now.


Should be EnableFollowerHandleRegion?

As we discussed in pr, the variable names of pd client will not change for now. At present, we only need to define the names directly exposed to users in TiDB.

Got it, I remember that.

ti-chi-bot · 2024-01-02T08:50:58Z

[LGTM Timeline notifier]

Timeline:

2024-01-02 08:22:21.037367694 +0000 UTC m=+2158832.074594621: ☑️ agreed by rleungx.
2024-01-02 08:50:57.207359333 +0000 UTC m=+2160548.244586258: ☑️ agreed by nolouch.

ti-chi-bot · 2024-01-04T07:55:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, nolouch, rleungx, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [tangenta]
~~pkg/domain/OWNERS~~ [tangenta]
~~pkg/sessionctx/variable/OWNERS~~ [easonn7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

CabinfeverB · 2024-01-04T08:14:30Z

/test pull-mysql-client-test

tiprow · 2024-01-04T08:14:51Z

@CabinfeverB: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test pull-mysql-client-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

CabinfeverB · 2024-01-04T10:25:17Z

/test check-dev2

tiprow · 2024-01-04T10:25:40Z

@CabinfeverB: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…rom pd follower (pingcap#49231) close pingcap#49747

CabinfeverB added 2 commits December 6, 2023 21:23

allow pd follower handle region api

461d0f9

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

allow pd follower handle region api

506e917

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Dec 6, 2023

CabinfeverB changed the title ~~go mod: upgrade client-go to support get region from pd follower~~ vars: add tidb_enable_pd_follower_handle to support get region from pd follower Dec 7, 2023

CabinfeverB added 2 commits December 25, 2023 10:08

merge master

599e7b6

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

rename

5a4351d

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

ti-chi-bot bot removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Dec 25, 2023

rename

2b19842

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 25, 2023

CabinfeverB changed the title ~~vars: add tidb_enable_pd_follower_handle to support get region from pd follower~~ vars: add tidb_enable_pd_follower_handle_region_api to support get region from pd follower Dec 25, 2023

add comment

bfbcfea

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

CabinfeverB marked this pull request as ready for review December 25, 2023 08:57

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 25, 2023

rename

7af8d7c

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com> rename Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

merge master

6e72492

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

CabinfeverB mentioned this pull request Dec 28, 2023

Activate Follower-Handle tikv/pd#7431

Closed

3 tasks

CabinfeverB added 2 commits January 2, 2024 10:57

Merge branch 'master' into follower/pd_follower_active

88fb655

update

1468566

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

nolouch reviewed Jan 2, 2024

View reviewed changes

address comment

00d509f

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

CabinfeverB changed the title ~~vars: add pd_enable_follower_region_api to support get region from pd follower~~ vars: add pd_enable_follower_handle_region to support get region from pd follower Jan 2, 2024

rleungx reviewed Jan 2, 2024

View reviewed changes

rleungx approved these changes Jan 2, 2024

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 2, 2024

nolouch approved these changes Jan 2, 2024

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 2, 2024

tangenta approved these changes Jan 4, 2024

View reviewed changes

ti-chi-bot bot added the approved label Jan 4, 2024

merge master

65d2b14

Signed-off-by: Cabinfever_B <cabinfeveroier@gmail.com>

ti-chi-bot bot merged commit e8861cf into pingcap:master Jan 4, 2024
22 checks passed

AilinKid pushed a commit to AilinKid/tidb that referenced this pull request Jan 17, 2024

vars: add pd_enable_follower_handle_region to support get region f…

c1af9d7

…rom pd follower (pingcap#49231) close pingcap#49747

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vars: add `pd_enable_follower_handle_region` to support get region from pd follower #49231

vars: add `pd_enable_follower_handle_region` to support get region from pd follower #49231

CabinfeverB commented Dec 6, 2023 •

edited

Loading

ti-chi-bot bot commented Dec 6, 2023

tiprow bot commented Dec 6, 2023

CabinfeverB commented Dec 6, 2023

CabinfeverB commented Dec 6, 2023

CabinfeverB commented Dec 25, 2023

CabinfeverB commented Dec 25, 2023

tiprow bot commented Dec 25, 2023

CabinfeverB commented Dec 25, 2023

codecov bot commented Dec 25, 2023 •

edited

Loading

CabinfeverB commented Dec 27, 2023

ti-chi-bot bot commented Dec 27, 2023

CabinfeverB commented Dec 28, 2023

CabinfeverB commented Jan 2, 2024

easonn7 commented Jan 2, 2024

nolouch Jan 2, 2024

rleungx Jan 2, 2024

CabinfeverB Jan 2, 2024

rleungx Jan 2, 2024

ti-chi-bot bot commented Jan 2, 2024

ti-chi-bot bot commented Jan 4, 2024

CabinfeverB commented Jan 4, 2024

tiprow bot commented Jan 4, 2024

CabinfeverB commented Jan 4, 2024

tiprow bot commented Jan 4, 2024

vars: add pd_enable_follower_handle_region to support get region from pd follower #49231

vars: add pd_enable_follower_handle_region to support get region from pd follower #49231

Conversation

CabinfeverB commented Dec 6, 2023 • edited Loading

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

ti-chi-bot bot commented Dec 6, 2023

tiprow bot commented Dec 6, 2023

CabinfeverB commented Dec 6, 2023

CabinfeverB commented Dec 6, 2023

CabinfeverB commented Dec 25, 2023

CabinfeverB commented Dec 25, 2023

tiprow bot commented Dec 25, 2023

CabinfeverB commented Dec 25, 2023

codecov bot commented Dec 25, 2023 • edited Loading

Codecov Report

CabinfeverB commented Dec 27, 2023

ti-chi-bot bot commented Dec 27, 2023

CabinfeverB commented Dec 28, 2023

CabinfeverB commented Jan 2, 2024

easonn7 commented Jan 2, 2024

nolouch Jan 2, 2024

Choose a reason for hiding this comment

rleungx Jan 2, 2024

Choose a reason for hiding this comment

CabinfeverB Jan 2, 2024

Choose a reason for hiding this comment

rleungx Jan 2, 2024

Choose a reason for hiding this comment

ti-chi-bot bot commented Jan 2, 2024

[LGTM Timeline notifier]

ti-chi-bot bot commented Jan 4, 2024

CabinfeverB commented Jan 4, 2024

tiprow bot commented Jan 4, 2024

CabinfeverB commented Jan 4, 2024

tiprow bot commented Jan 4, 2024

vars: add `pd_enable_follower_handle_region` to support get region from pd follower #49231

vars: add `pd_enable_follower_handle_region` to support get region from pd follower #49231

CabinfeverB commented Dec 6, 2023 •

edited

Loading

codecov bot commented Dec 25, 2023 •

edited

Loading