-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: refactor some code of the binding package #49009
Conversation
Hi @qw4990. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49009 +/- ##
================================================
+ Coverage 70.9775% 72.2661% +1.2885%
================================================
Files 1368 1397 +29
Lines 404391 416030 +11639
================================================
+ Hits 287027 300649 +13622
+ Misses 97368 96455 -913
+ Partials 19996 18926 -1070
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/cc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elsa0520, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
} | ||
|
||
// lastUpdateTime records the last update time for the global sql bind cache. | ||
// This value is used to avoid reload duplicated bindings from storage. | ||
lastUpdateTime types.Time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I ask why do we need to move it out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make the global cache clearer, since actually this variable is only used to record the last Update
time, which should not be put in the global cache structure.
What problem does this PR solve?
Issue Number: ref #48875
Problem Summary: planner: refactor some code of the binding package
What changed and how does it work?
planner: refactor some code of the binding package
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.