server: Set default drainClientWait as 15s (#42134) #48944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
release-note-none
12 tasks
ti-chi-bot
added
the
type/cherry-pick-for-release-6.5
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
size/M
ti-chi-bot
added
the
cherry-pick-approved
djshow832
force-pushed
the
cherry-pick-42134-to-release-6.5
branch
from
edcfb2c
to
8059f67
Compare
ti-chi-bot
bot
added
size/S
xhebox
approved these changes
Nov 28, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
djshow832
approved these changes
Nov 28, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: djshow832, xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #48944 +/- ##
================================================
Coverage ? 73.6311%
================================================
Files ? 1087
Lines ? 349427
Branches ? 0
================================================
Hits ? 257287
Misses ? 75621
Partials ? 16519 |
crazycs520
pushed a commit
to crazycs520/tidb
that referenced
this pull request
Nov 29, 2023
crazycs520
added a commit
that referenced
this pull request
Nov 29, 2023
djshow832
added a commit
to djshow832/tidb
that referenced
this pull request
Dec 1, 2023
…ingcap#48944)" This reverts commit 877198d.
ti-chi-bot
removed
the
cherry-pick-approved
ti-chi-bot
added
the
cherry-pick-approved
guoshouyan
pushed a commit
to guoshouyan/tidb
that referenced
this pull request
Mar 5, 2024
…8944) (pingcap#48990) (pingcap#32) close pingcap#32110 Co-authored-by: crazycs <crazycs520@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #42134
What problem does this PR solve?
Issue Number: close #32110
Problem Summary:
What is changed and how it works?
ref #32111
Set default drainClientWait as 15s
The default keeps waiting maybe too rigorous, It is easy having little slow txns which we may not want to wait for them, also the idle connections may block the shutdown two.
generally, 15s is enough for an ongoing txn to finish, better provider a dynamic way to set this value.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.